butterknife: ButterKnife generates ViewBinding class with wrong resource ID

I am using a 3rd-party library in our project, and compilation works fine, but the app crashes when it starts up. I looked at the logcat and generate source code, it seems the generated source code has the wrong resource ID.

For example, the source file is

class HomeActivity ... {
    @BindView(R2.id.mode_transition_layout) AppModeTransitionLayout modeTransitionLayout;

    @Override
    protected void onCreate(@Nullable Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);

        setContentView(R.layout.activity_main);
        ButterKnife.bind(this);

The generated HomeActivity_ViewBinding class has

  @UiThread
  public HomeActivity_ViewBinding(T target, View source) {
    this.target = target;

    target.modeTransitionLayout = Utils.findRequiredViewAsType(source, R.id.infant_description_text, "field 'modeTransitionLayout'", AppModeTransitionLayout.class);
  }

R.id.infant_description_text is a different resource ID, and I’d assume here should use R.id.mode_transition_layout.

At the runtime I get an exception says java.lang.IllegalStateException: Required view 'infant_description_text' with ID 2131822441 for field 'modeTransitionLayout' was not found. If this view is optional add '@Nullable' (fields) or '@Optional' (methods) annotation.

We are using ButterKnife 8.4.0.

Any help is highly appreciated!

About this issue

Original URL
State: closed
Created 8 years ago
Comments: 29 (5 by maintainers)

Commits related to this issue

Adds failing test for #779 — committed to felipecsl/butterknife by felipecsl 8 years ago
Fixes #779 by scoping symbols by package — committed to felipecsl/butterknife by felipecsl 8 years ago
Cherry-pick https://github.com/JakeWharton/butterknife/pull/788. This PR does not work with projects that use butterknife in application modules!! Squashed commit of the following: commit 02a845fa46... — committed to BenSchwab/butterknife by BenSchwab 7 years ago
Adds failing test for #779 — committed to mrhether/butterknife by felipecsl 8 years ago
Fixes #779 by scoping symbols by package — committed to mrhether/butterknife by felipecsl 8 years ago

Most upvoted comments

i am seeing this issue with 8.8.1 too. especially after adding a new xml layout via copy and paste, and then renaming some ids (not refactoring)

The only secure way is to delete the app/build folder and rebuild the project

mlostekk on Mar 12, 2018

Same problem in my project. I have tested with various versions of ButterKnife. Version 8.5.1 works fine. Version 8.6.0 and all above stable produces this error. Cleaning project not resolves this problem.

swapii on Aug 15, 2017

we’re still seeing this problem, sounds like a legit butterknife bug. @engian i’d recommend reopening

felipecsl on Oct 19, 2016

@JakeWharton I fixed my issue, for your reference, here is the build config I changed:

Before (generated code with wrong resource ID):

library ‘core’ depends on 3rd-party library
library ‘lib’ depends on ‘core’ and 3rd-party library
module ‘app’ depends on ‘lib’

I removed the dependency from ‘core’ to 3rd-party library and butterknife works properly.

Our of curiosity, is there a way to invoke butterknife from command line for debugging?

engian on Oct 19, 2016

I’m also seeing this issue again, but only when using the Android Gradle Plugin 3.0.0 beta

felipecsl on Oct 3, 2017

Cool, I have tried 8.5.2-SNAPSHOT and it works now. Please help to release it once it passes all the test. Thanks so much for you guys’ support!

zhfk930129 on Mar 7, 2017

I am not dealing with this issue anymore. Fortunately or not, I’ve replaced it by native dataBinding.

mmmattos on Mar 13, 2018

I have experienced the same issue at the first time and start looking to eliminate butterknife annotation one by one. After I remove all of @BindColor and @BindArray on library project, the butterknife able to generate the correct ViewBinding file. Maybe this could be a temporary solution.

7293hq on Jan 11, 2017

@engian does it happen on clean builds? Sounds similar to #776.

JakeWharton on Oct 18, 2016