istio: helm upgrade fail for 1.1.0-rc.0

root@m-1:~/istio-1.1.0-rc.0# helm upgrade --install istio install/kubernetes/helm/istio --namespace istio-system \
   --set ingress.enabled=true \
   --set gateways.istio-ingressgateway.enabled=true \
   --set gateways.istio-egressgateway.enabled=true \
   --set galley.enabled=true \
   --set sidecarInjectorWebhook.enabled=true \
   --set mixer.enabled=true \
   --set prometheus.enabled=true \
   --set global.hub=istionightly \
   --set global.tag=1.1.0-rc.0 \
   --set global.imagePullPolicy=Always \
   --set global.proxy.envoyStatsd.enabled=true \
   --set global.mtls.enabled=true \
   --set security.selfSigned=false \
   --set global.enableTracing=true \
   --set global.proxy.autoInject=true \
   --set tracing.enabled=true \
   --tls

Error: UPGRADE FAILED: YAML parse error on istio/charts/ingress/templates/deployment.yaml: error converting YAML to JSON: yaml: line 50: did not find expected key
root@m-1:~/istio-1.1.0-rc.0# pwd
/root/istio-1.1.0-rc.0

About this issue

Original URL
State: closed
Created 5 years ago
Comments: 34 (31 by maintainers)

Most upvoted comments

@sdake looks like there are several conversations in different threads. Let me summarize everything here.

“ingress.enabled” != Kubernetes Ingress resource support
“ingress.enabled” is known to be broken and should not be used, we need to remove it. Here’s a PR for this: https://github.com/istio/istio/pull/12284 (similar to your PR from yesterday, see the PR notes highlighting the key differences).
After that PR is merged, we will need to remote “ingress.gateway” installer flags from the Istio.io documentation, there’s no PR for that yet, I can do it once 12284 is merged. Also we probably need to indicate that “ingress.enabled” flag is removed in the 1.1 release notes (not sure how to handle this one).
Kubernetes Ingress resource support works and is tested, it can be enabled via “global.k8sIngress.enabled” flag and will by default be handled by “ingressgateway” since https://github.com/istio/istio/pull/12284
This is documented in my docs PR that demonstrates the use of k8sIngress, this example does not rely on “ingress.enabled” (that is what’s being removed): https://github.com/istio/istio.io/pull/3498

I think this is all there is to it. Let me know if this makes sense. Also would appreciate any help with getting those 2 PRs in. Thanks!

philrud on Mar 6, 2019