ionic-framework: bug: ios native refresher refreshes too early when used in modal
Bug Report
Ionic version:
[ ] 4.x [x] 5.x
Current behavior:
I use a Refresher within a Modal (iOS Card Style). It behaves not like as i expect, because it doesn’t have the native look like the other refreshers. while i would expect the refresher to “show more” as more i pull down, it bugs, and start the refreshing very early.
Also in noticed that the spinner in my project is kind of behind the list (but visible) and only hides if i press or move anything.
Expected behavior:
The Refresher should work in a Mode where anywhere else.
Steps to reproduce:
I have created a small Repo: https://github.com/EinfachHans/ionic-refresher-bug It contains the “main” bug, but i can’t reproduce the other bug that the spinner is over the list, so i create a small video to help you. Maybe you have an idea or it’s related to the same underlaying issue?
Ionic info:
Cordova:
Cordova CLI : 10.0.0
Cordova Platforms : ios 6.1.1
Cordova Plugins : cordova-plugin-ionic-keyboard 2.2.0, cordova-plugin-ionic-webview 5.0.0, (and 24 other plugins)
Utility:
cordova-res : 0.15.1
native-run (update available: 1.2.1) : 1.0.0
System:
Android SDK Tools : 25.2.3 (/Users/hanskrywalsky/Library/Android/sdk)
ios-deploy : 1.10.0
ios-sim : 8.0.2
NodeJS : v12.18.3 (/usr/local/bin/node)
npm : 6.14.8
OS : macOS Catalina
Xcode : Xcode 12.0.1 Build version 12A7300
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 18 (17 by maintainers)
Commits related to this issue
- fix(refresher): work properly in modal by waiting for content to be ready (#22390) resolves #22256 — committed to ionic-team/ionic-framework by EinfachHans 4 years ago
- fix(refresher): work properly in modal by waiting for content to be ready (#22390) resolves #22256 — committed to TakumaKira/ionic-framework by EinfachHans 4 years ago
Thank you! I will take a look this week.
@liamdebeasi - Thx again, with this help i was able to determine the underlaying bug. The
scrollListenerCallbackitself was correct, the error was the scrollEl’s offsetHeight to be zero.PR created: #22390
Would be great if you can include this in one of the upcoming bug-fixing releases 😊🎉
@liamdebeasi thx!! That helps me very much 😃 will look into this next week! ❤️