telegraf: inputs.zfs: pools tag wrongly populated
Relevant telegraf.conf
[[inputs.zfs]]
kstatPath = "/proc/spl/kstat/zfs"
kstatMetrics = ["arcstats", "zfetchstats", "vdev_cache_stats", "vdev_mirror_stats", "zil", "dmu_tx"]
poolMetrics = true
[inputs.zfs.tagdrop]
dataset = [ "data/docker/*" ]
Logs from Telegraf
not relevant
System info
Telegraf 1.21.4
Docker
No response
Steps to reproduce
My host has a single pool
# zpool list | grep -v DEDUP | wc -l
1
but telegraf seems to populate pools
tag wrongly:
# /usr/bin/telegraf -config /etc/telegraf/telegraf.conf -config-directory /etc/telegraf/telegraf.d --test --input-filter zfs
....
> zfs,host=my.host.name,pools=data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data::data arcstats_abd_chunk_waste_size=166206976i,arcstats_access_skip=2244i,arcstats_anon_evictable_data=0i,arcstats_anon_evictable_metadata=0i,arcstats_anon_size=5509632i,arcstats_arc_dnode_limit=10138581073i,arcstats_arc_loaned_bytes=0i,arcstats_arc_meta_limit=101385810738i,arcstats_arc_meta_max=40165323706i,arcstats_arc_meta_min=16777216i,arcstats_arc_meta_used=17998455584i,arcstats_arc_need_free=0i,arcstats_arc_no_grow=1i,arcstats_arc_prune=0i,arcstats_arc_raw_size=0i,arcstats_arc_sys_free=8947955968i,arcstats_arc_tempreserve=0i,arcstats_async_upgrade_sync=558516i,arcstats_bonus_size=563653120i,arcstats_c=135179508121i,arcstats_c_max=135181080985i,arcstats_c_min=8448817408i,arcstats_cached_only_in_progress=0i,arcstats_compressed_size=120897560576i,arcstats_data_size=117055417344i,arcstats_dbuf_size=805906176i,arcstats_deleted=142411626i,arcstats_demand_data_hits=1450764076i,arcstats_demand_data_misses=109784173i,arcstats_demand_hit_predictive_prefetch=4759929i,arcstats_demand_hit_prescient_prefetch=0i,arcstats_demand_metadata_hits=2931378777i,arcstats_demand_metadata_misses=35154774i,arcstats_dnode_size=1969264832i,arcstats_evict_l2_cached=0i,arcstats_evict_l2_eligible=16106026339840i,arcstats_evict_l2_eligible_mfu=2278722769408i,arcstats_evict_l2_eligible_mru=13827303570432i,arcstats_evict_l2_ineligible=889175123968i,arcstats_evict_l2_skip=0i,arcstats_evict_not_enough=2888i,arcstats_evict_skip=44276i,arcstats_hash_chain_max=6i,arcstats_hash_chains=524449i,arcstats_hash_collisions=74524995i,arcstats_hash_elements=6311776i,arcstats_hash_elements_max=7052493i,arcstats_hdr_size=2046783840i,arcstats_hits=4386032944i,arcstats_l2_abort_lowmem=0i,arcstats_l2_asize=0i,arcstats_l2_bufc_data_asize=0i,arcstats_l2_bufc_metadata_asize=0i,arcstats_l2_cksum_bad=0i,arcstats_l2_data_to_meta_ratio=0i,arcstats_l2_evict_l1cached=0i,arcstats_l2_evict_lock_retry=0i,arcstats_l2_evict_reading=0i,arcstats_l2_feeds=0i,arcstats_l2_free_on_write=0i,arcstats_l2_hdr_size=0i,arcstats_l2_hits=0i,arcstats_l2_io_error=0i,arcstats_l2_log_blk_asize=0i,arcstats_l2_log_blk_avg_asize=0i,arcstats_l2_log_blk_count=0i,arcstats_l2_log_blk_writes=0i,arcstats_l2_mfu_asize=0i,arcstats_l2_misses=0i,arcstats_l2_mru_asize=0i,arcstats_l2_prefetch_asize=0i,arcstats_l2_read_bytes=0i,arcstats_l2_rebuild_asize=0i,arcstats_l2_rebuild_bufs=0i,arcstats_l2_rebuild_bufs_precached=0i,arcstats_l2_rebuild_cksum_lb_errors=0i,arcstats_l2_rebuild_dh_errors=0i,arcstats_l2_rebuild_io_errors=0i,arcstats_l2_rebuild_log_blks=0i,arcstats_l2_rebuild_lowmem=0i,arcstats_l2_rebuild_size=0i,arcstats_l2_rebuild_success=0i,arcstats_l2_rebuild_unsupported=0i,arcstats_l2_rw_clash=0i,arcstats_l2_size=0i,arcstats_l2_write_bytes=0i,arcstats_l2_writes_done=0i,arcstats_l2_writes_error=0i,arcstats_l2_writes_lock_retry=0i,arcstats_l2_writes_sent=0i,arcstats_memory_all_bytes=270362157056i,arcstats_memory_available_bytes=35207853824i,arcstats_memory_direct_count=88i,arcstats_memory_free_bytes=44155809792i,arcstats_memory_indirect_count=52810i,arcstats_memory_throttle_count=0i,arcstats_metadata_size=12612847616i,arcstats_mfu_evictable_data=87273374208i,arcstats_mfu_evictable_metadata=4536085504i,arcstats_mfu_ghost_evictable_data=2649269248i,arcstats_mfu_ghost_evictable_metadata=28012506112i,arcstats_mfu_ghost_hits=8542218i,arcstats_mfu_ghost_size=30661775360i,arcstats_mfu_hits=2942459455i,arcstats_mfu_size=98929982464i,arcstats_misses=161036178i,arcstats_mru_evictable_data=22843074560i,arcstats_mru_evictable_metadata=16384i,arcstats_mru_ghost_evictable_data=35797590016i,arcstats_mru_ghost_evictable_metadata=68669623808i,arcstats_mru_ghost_hits=20597828i,arcstats_mru_ghost_size=104467213824i,arcstats_mru_hits=1441152987i,arcstats_mru_size=30732772864i,arcstats_mutex_miss=68373i,arcstats_overhead_size=8770704384i,arcstats_p=48174970732i,arcstats_prefetch_data_hits=495615i,arcstats_prefetch_data_misses=11626325i,arcstats_prefetch_metadata_hits=3394476i,arcstats_prefetch_metadata_misses=4470906i,arcstats_size=135220079904i,arcstats_uncompressed_size=136110142976i,dmu_tx_assigned=619147416i,dmu_tx_delay=0i,dmu_tx_dirty_delay=0i,dmu_tx_dirty_frees_delay=4266i,dmu_tx_dirty_over_max=0i,dmu_tx_dirty_throttle=0i,dmu_tx_error=0i,dmu_tx_group=82i,dmu_tx_memory_reclaim=0i,dmu_tx_memory_reserve=0i,dmu_tx_quota=0i,dmu_tx_suspended=0i,vdev_cache_stats_delegations=0i,vdev_cache_stats_hits=0i,vdev_cache_stats_misses=0i,vdev_mirror_stats_non_rotating_linear=0i,vdev_mirror_stats_non_rotating_seek=0i,vdev_mirror_stats_preferred_found=121410498i,vdev_mirror_stats_preferred_not_found=39625431i,vdev_mirror_stats_rotating_linear=0i,vdev_mirror_stats_rotating_offset=0i,vdev_mirror_stats_rotating_seek=0i,zfetchstats_hits=39986117i,zfetchstats_io_issued=12118625i,zfetchstats_max_streams=926601998i,zfetchstats_misses=948685411i,zil_commit_count=16042i,zil_commit_writer_count=15839i,zil_itx_copied_bytes=0i,zil_itx_copied_count=0i,zil_itx_count=164155i,zil_itx_indirect_bytes=809683738i,zil_itx_indirect_count=6210i,zil_itx_metaslab_normal_bytes=1407378072i,zil_itx_metaslab_normal_count=24664i,zil_itx_metaslab_slog_bytes=0i,zil_itx_metaslab_slog_count=0i,zil_itx_needcopy_bytes=1372731688i,zil_itx_needcopy_count=139789i 1647512269000000000
Expected behavior
Since there is only one pool in the host, I would expect the pools
tag value to be just data
Actual behavior
Instead I get a concatenated list of data
strings.
Additional info
No response
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 15 (12 by maintainers)
After looking at this some more, I agree with your suggestion! I have put up #10871, if @kosfar could give that a try once build artifacts are attached to the PR that would be great.
Thanks!