ha-tahoma: Stop command doesn't work for some cover devices

Describe the bug Currently the cover implementation relies on the available commands of a cover device. However, when a stop command is present, it doesn’t mean that the stop command is functional. (thanks Somfy 👍🏻)

https://github.com/iMicknl/ha-tahoma/blob/23eaec1a7f6c9cc776d857ec45bbadca4d206bf0/custom_components/tahoma/cover.py#L217-L221

To Reproduce Steps to reproduce the behavior:

  1. Open or close cover
  2. Press stop button
  3. Cover device doesn’t stop moving

Additional context The integration is not consistent in how it handles a stop command. For example, for the cover_tilt mainly used by Pergolas, we first execute COMMAND_STOP_IDENTIFY since STOP didn’t work for my own device…

https://github.com/iMicknl/ha-tahoma/blob/23eaec1a7f6c9cc776d857ec45bbadca4d206bf0/custom_components/tahoma/cover.py#L223-L227

Best would be to:

First use COMMAND_STOP_IDENTIFY or COMMAND_MY to stop a moving cover. This needs to be thoroughly tested to ensure it doesn’t cause problems with covers that are not experiencing this issue.

OR

Make sure entities can set their preferred stop method via customize.yaml, as a workaround. I am not a fan of having all those device specific if statements in the integration.

Environment (please complete the following information):

  • Platform: cover

Device: (if your problem is related to a specific device)

  • AwningComponent (io:HorizontalAwningIOComponent) (see #59
  • ExteriorScreen (rts:ExteriorBlindRTSComponent) (see #43)

About this issue

  • Original URL
  • State: closed
  • Created 4 years ago
  • Comments: 23 (10 by maintainers)

Most upvoted comments

Great to hear that you’re so active! I bought the Tahoma box recently and I’m really happy to see that you and the others rewrite this component. I manually pull the master branch into my custom_components, I try to update all my dependencies a couple of times per week 😃 Looking forward to what’s coming!

@golles thanks for first looking at closed issues / pr’s 😄! This PR took a bit longer to get merged, but I will do a new release soon with some more fixes.

For now, you could install the latest master via HACS or manually.

@iMicknl i just tested your new version. Everything worked well and no errors showing up. Nice work!

yes tahomalink!