cyclone-physics: Buoyancy force appears to be calculated incorrectly

In my opinion the calculation of the buoyancy is incorrect (file pfgen.cpp lines 120 and 121).

I think the correct calculation should look like this:

    force.y = liquidDensity * volume *
        (depth - maxDepth - waterHeight) / (2 * maxDepth);

Current code is missing the parentheses around “2 * maxDepth”

About this issue

  • Original URL
  • State: open
  • Created 7 years ago
  • Comments: 15 (3 by maintainers)

Most upvoted comments

force.y = liquidDensity * volume *
        (maxDepth  + waterHeight - depth) / (2 * maxDepth);