i3: Some keybindings does not work when num lock is enabled

Output of i3 --moreversion 2>&- || i3 --version:

Binary i3 version:  4.12-118-g155f034 (2016-08-03, branch "gaps-next") © 2009 Michael Stapelberg and contributors
(Getting version from running i3, press ctrl-c to aborRunning i3 version: 4.12-118-g155f034 (2016-08-03, branch "gaps-next") (pid 2882)
Loaded i3 config: /home/k-bag/.i3/config (Last modified: sam. 06 août 2016 15:20:19 MSK, 289 seconds ago)

The i3 binary you just called: /usr/bin/i3
The i3 binary you are running: i3

The logfile: _http://logs.i3wm.org/logs/5719570367119360.bz2_

What I did:

  • Use i3 with the default /etc/i3/config file
  • Enable numpad
  • Launch resize mode with $mod+r
  • Press escape to quit the mode

What I saw:

Nothing, the escape key is not taken account.

What I expected instead:

Quit the resize mode when pressing escape.

Notes

Note that a lot of combinaisons does not work when num lock is enabled (All keybindings where shift is involved, e.g $mod+shift+r to restart i3). This behavior started after d77d40173aa

About this issue

  • Original URL
  • State: closed
  • Created 8 years ago
  • Reactions: 8
  • Comments: 36 (20 by maintainers)

Commits related to this issue

Most upvoted comments

Looking at this now.

Should be fixed now as well.

@stapelberg: With the default config at commit 2244c84 and US keyboard layout, resize mode works correctly, but most regular keybindings with Shift still do not work with NumLock. Here is what I’ve found for all Mod1+Shift+... keybindings in the default config:

Working:

  • Mod1+Shift+Left
  • Mod1+Shift+Down
  • Mod1+Shift+Up
  • Mod1+Shift+Right
  • Mod1+Shift+space

Not working:

  • Mod1+Shift+q
  • Mod1+Shift+$left
  • Mod1+Shift+$down
  • Mod1+Shift+$up
  • Mod1+Shift+$right
  • Mod1+Shift+minus
  • Mod1+Shift+1 (and the rest of the number keys)
  • Mod1+Shift+c
  • Mod1+Shift+r
  • Mod1+Shift+e

This issue should now be fixed. If you still encounter keybindings which don’t work with numlock enabled, please let me know how to reproduce (ideally, with the default i3 config aside from one addition, and with the US keyboard layout).

I’m still working the RandR 1.5 changes (took notes on the airplane, need to realize them via git still), but looking at the commit in question, this oughtn’t be too bad to figure. I guess this part needs review:

we now check whether the key has the same meaning when NumLock is enabled.