next-i18next: Babel doesn't polyfill according preset-env
Describe the bug
As mentioned in https://github.com/isaachinman/next-i18next/issues/107 I expected that es6 functions are polyfilled but it’s not. If you check the dist/es/utils/lng-path-corrector there is no polyfill for Array.includes. This throws in IE Edge.
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 25 (19 by maintainers)
BrowserStack has been kind enough to support the project and I’ve had a chance to test this in IE11. Should be fully supported with #402.
I’ve now brought the simple example online via Heroku and have updated the README. I’ve allocated a domain and the live demo can be found at next-i18next.com.
We can use this domain to do browser testing, etc, going forward.
I think you misunderstood my question. This package,
next-i18next, transpiles to two separate targets.Upgrading your Node version is not going to do anything for your browser support. You’ll need to do one of these things:
node_modulesbabelrcAs I’ve stated, I’d very much like for this package to support the exact same browsers that NextJs does, because this package is an enhancement on top of NextJs.
We transpile to the same target that NextJs does. Polyfilling is up to the user. Am I misunderstanding?