hyprland-plugins: New plugin hyprexpo fails to build

I’ve added some stuff so that it’s like this now:

worth noting it won’t work retroactively, it’s available in git now. Is that enough?

Ignore the duplicate bars its me being a bit goof

makes sense. I’ll try to do something about the UX tomorrow.

Okay several issues:

• Yes the version matters, but since @vaxerski first said it needed to be “today’s Git”, it has changed again. Now it needs to be a version ever after what was posted at the time that was said. I guess the plugin and compositor commits are ratcheting up on eachother.
• You can’t update the package and rebuild the plugins, it doesn’t use the libraries installed on the system it uses it’s own vendored copy of what is running on the system. That means you have to restart the running compositor before trying to build plugins.
• You can’t build plugins without the compositor running. A tmux session left open while the Wayland session logged out and back in won’t gut it. You have to be in a child process of the currently running compositor to build plugins.

Tag: v0.38.0-21-g36a8ae9b works (to build at least, haven’t tried using it) given those other points.

This brings us back to UX. The experience of trying to build plugins is quite opaque and the errors point nowhere useful for any of this. The running sessions vs. downloaded vendored copy of hyprland source code needs to be explained, as does the issue wind needing to be in a running copy, and of course plugins should clearly identify a minimum version and that should produce a different error than any of the above.

oh wait, I misread the thing.

Uhh yeah hyprexpo won’t build cuz you’re on tagged. hyprexpo is -git only. (or, well future 0.39)

❯ hyprpm add https://github.com/hyprwm/hyprland-plugins.git --verbose
[v] version returned: Hyprland, built from branch main at commit 10146f5ec50caeae2d835f5f6296137e2ac6f243 dirty (core: fix some crash conditions around workspace ptrs in CWindow).
Date: Wed Apr 3 21:42:38 2024
Tag: v0.38.0-18-g10146f5e

flags: (if any)


[v] parsed commit 10146f5ec50caeae2d835f5f6296137e2ac6f243 at branch main

[...]

 → Building hyprexpo                                                                                                                               
 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╍━━━━━━━━━━━━━━━━━━━  3 / 5  Building plugin(s)[v] shell returned:  -> cd /tmp/hyprpm/new && PKG_CONFIG_PATH="/home/yusuf/.local/share/hyprpm/headersRoot/share/pkgconfig" make -C hyprexpo all
make: Entering directory '/tmp/hyprpm/new/hyprexpo'
g++ -shared -fPIC --no-gnu-unique main.cpp overview.cpp -o hyprexpo.so -g `pkg-config --cflags pixman-1 libdrm hyprland` -std=c++2b -Wno-narrowing
overview.cpp: In constructor ‘COverview::COverview(PHLWORKSPACE, bool)’:
overview.cpp:144:37: error: ‘struct SCurrentRenderData’ has no member named ‘blockScreenShader’
  144 |         g_pHyprOpenGL->m_RenderData.blockScreenShader = true;
      |                                     ^~~~~~~~~~~~~~~~~
overview.cpp: In member function ‘void COverview::redrawID(int, bool)’:
overview.cpp:261:33: error: ‘struct SCurrentRenderData’ has no member named ‘blockScreenShader’
  261 |     g_pHyprOpenGL->m_RenderData.blockScreenShader = true;
      |                                 ^~~~~~~~~~~~~~~~~
make: *** [Makefile:2: all] Error 1
make: Leaving directory '/tmp/hyprpm/new/hyprexpo'


✖ Plugin hyprexpo failed to build.    

also about the “it only builds for the newest version”, shouldn’t hyprpm skip the plugin then if it isn’t for the version?

expo needs today’s git. Add -v to your hyprpm command to see what went wrong