SwiftEntryKit: Unable to dismiss a ViewControllerEntry in Xcode 10.2 (work in Xcode 10.1)
Describe the bug Unable to dismiss a ViewControllerEntry by a “screenInteraction” in Xcode 10.2. However, it works in Xcode 10.1.
To Reproduce Steps to reproduce the behavior:
- Open a ViewControllerEntry
- Click outside the entry (screenInteraction)
- Even if the screenInteraction is set to .dismiss, the behavior works like a .forward
Expected behavior
When I click outside the entry, I would like to dismiss the entry.
To do this, I set :
attributes.screenInteraction = .dismiss
Configuration
- iPhone X, iPhone XS, iPhone XR on Simulator
- iOS 12.x.x
- Xcode Version 10.2
- SwiftEntryKit 0.8.6 and SwiftEntryKit 0.8.9
Additional context My configuration works perfectly on Xcode 10.1, and bug in Xcode 10.2
Thanks in advance,
Rémi Rodrigues,
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 20 (8 by maintainers)
Commits related to this issue
- #171 Unable to dismiss a ViewControllerEntry in Xcode 10.2 (work in Xcode 10.1). Diagnosis: Only on Xcode 10.2. Probably be a Swift compiler bug. Reproduced using Release configuration. The compiler m... — committed to huri000/SwiftEntryKit by huri000 5 years ago
- Merge pull request #173 from huri000/bugfix/xcode-10.2-compiler #171 Unable to dismiss a ViewControllerEntry in Xcode 10.2 (work in X… — committed to huri000/SwiftEntryKit by huri000 5 years ago
Thanks @huri000 for the prompt fix and incredible library!
The problem has been resolved. Thank you!!
Hi Daniel,
I confirm you that your fix works fine !
Thanks for your reactivity
Managed to reproduce this thanks to @jangsy7883, and to the consistent weirdness of the Swift compiler. I’ll file an issue with Apple since it is definitely a compiler issue, but I should also be able to resolve this by changing the internal code. I’ll keep you all posted as soon as possible.