php-scoper: [Scoper] Scoping autoloaded files result in an autoload conflict

Understood - however I am not sure how to catch this in scoper - when one is supposed to dump the autoloader after using scoper.

What solved it for me was this simple script"

<?php
/**
 * This helper is needed to "trick" composer autoloader to load the prefixed files
 * Otherwise if owncloud/core contains the same libraries ( i.e. guzzle ) it won't
 * load the files, as the file hash is the same and thus composer would think this was already loaded
 *
 * More information also found here: https://github.com/humbug/php-scoper/issues/298
 */
$scoper_path = './build/scoper/vendor/composer';
$static_loader_path = $scoper_path.'/autoload_static.php';
echo "Fixing $static_loader_path \n";
$static_loader = file_get_contents($static_loader_path);
$static_loader = \preg_replace('/\'([A-Za-z0-9]*?)\' => __DIR__ \. (.*?),/', '\'a$1\' => __DIR__ . $2,', $static_loader);
file_put_contents($static_loader_path, $static_loader);
$files_loader_path = $scoper_path.'/autoload_files.php';
echo "Fixing $files_loader_path \n";
$files_loader = file_get_contents($files_loader_path);
$files_loader = \preg_replace('/\'(.*?)\' => (.*?),/', '\'a$1\' => $2,', $files_loader);
file_put_contents($files_loader_path, $files_loader);

I ran into the same problem recently, and took the advice here to edit the autoload_static.php after the scoping process. I simply bolted it onto my gulp build process with a function like this (which uses the gulp-replace plugin):

// Need to prefix hashes in autoload_static.php to ensure they don't conflict with any other autoloaded packages
// This is because other WordPress plugins might use same packages, scoped differently (or not scoped at all) and get loaded first (or not loaded at all)
// Which could cause our plugin to fail, or their plugins to fail. So we need to ensure each entry has a unique hash by simply adding a prefix.
const composerScopeAutoload = () => {
	return src(["path/to/vendor/composer/autoload_static.php"])
		.pipe(replace(/\'([A-Za-z0-9]*?)\' => __DIR__ \. (.*?),/g, '\'myprefix$1\' => __DIR__ . $2,'))
		.pipe(dest(`dist/vendor/composer`));
};

So as per the discussion in https://github.com/composer/composer/issues/7942, I changed my mind and I think it makes sense for PHP-Scoper to change the names of the scoped packages.

So I guess a solution would be to also change the packages names in composer.json and installed.json to solve the issue, maybe by just appending the prefix to the name.

The concerned code is this one I think: https://github.com/humbug/php-scoper/tree/ddcf428/src/Scoper/Composer

So if we could somehow make it possible to hook into the post autoload dump section, we can run whatever fix we think is necessary + you could provide a utitlity that contains the code above as a standard hook.

This IMO is a very fragile hook. So I’m not too keen to provide one there as in my experience, although users may be warn this is fragile and entirely there responsibility, ultimately there still end up coming to me (not always in a friendly way) about there special case.

However your case, or rather this issue, is much more general and IMO deserves a proper fix. Be it from Composer or within PhpScoper, either way is fine by me.

So if I understand correctly, you alter the autoload_static.php file to change the paths?

I’m here with the same problem, I have a WordPress plugin bundling the scoped AWS SDK, but it loads a functions file before another plugin with the SDK.

@theofidry have you had any further thoughts on this?

@patrickjahns is https://github.com/humbug/php-scoper/issues/298#issuecomment-525700081 still your working solution? Where does that code live? Found it https://github.com/owncloud/files_primary_s3/pull/237/files#diff-89e7fc97925a92c2521656947a720895

Update: Thanks @patrickjahns - works a treat!

👍 I’ll try to take a look ASAP but it’s likely gonna take a couple of weeks, this month is quite busy for me 😕

I’ll create a repo for you 👍