botkit: Typescript builds broken due to issue in botbuilder-streaming

There is a class definition missing from the botbuilder-streaming library that causes this error when building Botkit:

../../node_modules/botframework-streaming/lib/webSocket/browserWebSocket.d.ts(17,26): error TS2304: Cannot find name 'WebSocket'.

This currently blocks Botkit from building.

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 15 (7 by maintainers)

Commits related to this issue

Refactor constructor to smaller nonadic or monadic functions. Align for Step Down reading. @todo test until #1894 is resolved. — committed to roeintense/botkit by roeintense 4 years ago
Refactor constructor to smaller nonadic or monadic functions. Align for Step Down reading. TODO: cannot test until #1894 is resolved. — committed to roeintense/botkit by roeintense 4 years ago

Most upvoted comments

A fix for this is scheduled to be released next Monday.

benbrown on Jan 10, 2020

Botkit version 4.6.2

node_modules/botframework-streaming/lib/subscribableStream.d.ts:15:5 - error TS2416: Property '_write' in type 'SubscribableStream' is not assignable to the same property in base type 'Duplex'.
  Type '(chunk: any, encoding: string, callback: (error?: Error | null | undefined) => void) => void' is not assignable to type '(chunk: any, encoding: string, callback: (err?: Error | undefined) => void) => void'.
    Types of parameters 'callback' and 'callback' are incompatible.
      Types of parameters 'err' and 'error' are incompatible.
        Type 'Error | null | undefined' is not assignable to type 'Error | undefined'.
          Type 'null' is not assignable to type 'Error | undefined'.

15     _write(chunk: any, encoding: string, callback: (error?: Error | null) => void): void;

minhngvan on Feb 18, 2020

It was published yesterday. This issue is resolved.

benbrown on Jan 28, 2020

Small update, the fix is in the 4.7 branch of botbuilder-js. We have not yet released 4.7.1 as there is another fix we might take for this patch release.

stevengum on Jan 15, 2020