turbo: Promoted Frame Visits cause `tracked_element_mismatch` reloads
This only impacts main branch builds since https://github.com/hotwired/turbo/pull/887.
When promoting Frame Visits using data-turbo-action="…", Turbo will reload the page. The turbo:reload event reason is: tracked_element_mismatch. This only appears to be an issue since: #887
/cc @seanpdoyle
About this issue
- Original URL
- State: closed
- Created 8 months ago
- Reactions: 1
- Comments: 23 (15 by maintainers)
Commits related to this issue
- Render full documents for requests with `Turbo-Frame:` header Re-submission of [#232][] Related to [hotwired/turbo#1047][] Render full documents, including default layout rendering behavior. Render... — committed to seanpdoyle/turbo-rails by seanpdoyle 7 months ago
- Don't include Turbo-Frame header in promoted frame navigations This commit changes the behavior of frame navigations promoted with the `[data-turbo-action]` attribute so that they don't include the `... — committed to hotwired/turbo by afcapel 5 months ago
- Do not render page snapshot when navigating within a frame Fixes https://github.com/hotwired/turbo/issues/1047 Rendering a frame with a data-turbo-action was rendering the response twice. First, th... — committed to hotwired/turbo by afcapel 5 months ago
- Do not render page snapshot when navigating within a frame Fixes https://github.com/hotwired/turbo/issues/1047 Rendering a frame with a data-turbo-action was rendering the response twice. First, th... — committed to hotwired/turbo by afcapel 5 months ago
- Do not invalidate pages in visits that don't render (#1144) * Do not render page snapshot when navigating within a frame Fixes https://github.com/hotwired/turbo/issues/1047 Rendering a frame wi... — committed to hotwired/turbo by afcapel 5 months ago
- Render full documents for requests with `Turbo-Frame:` header Re-submission of [#232][] Related to [hotwired/turbo#1047][] Render full documents, including default layout rendering behavior. Render... — committed to seanpdoyle/turbo-rails by seanpdoyle 7 months ago
- Render full documents for requests with `Turbo-Frame:` header Re-submission of [#232][] Related to [hotwired/turbo#1047][] Render full documents, including default layout rendering behavior. Render... — committed to seanpdoyle/turbo-rails by seanpdoyle 7 months ago
@seanpdoyle https://github.com/domchristie/turbo_promoted_frame_visit_test
It appears to only impact turbo-rails setups. I tried a minimal demo, serving plain html files (where the frame visit response included a minimal layout to mimic the turbo-rails behaviour), and it worked.
Agreed, let’s get it fixed before v8 👍
@afcapel I think this is quite a major issue, since it breaks all Turbo Frames visits with a data-turbo-action. Would be good to get fixed before v8 is released