core: Tesla Integration - Error Communicating with API

Is it worth pre-empting this and just moving it into HACS? Reading over the comments, it seems like it’s almost certain this will get rejected as it goes against the “no web scraping” rule.

I get why the HA guys want to maintain certain standards, but when there’s no alternative, stalling stuff like this indefinitely just harms the userbase.

For what it’s worth, I applied the patch and it fixed it for me.

@qJake

1. cd to root “homeassistant” directory
2. wget https://patch-diff.githubusercontent.com/raw/home-assistant/core/pull/45766.diff
3. Run patch -p0 < ./45766.diff (or maybe -p1, I forget how it’s laid out).
4. Clean up any rejections due to the changes no longer cleanly applying to your version of Home Assistant.
5. Restart Home Assistant
6. Delete the Tesla integration from the integrations page
7. Re-add the Tesla integration from the integrations page (you’ll need to supply your login credentials again)

Fortunately, I didn’t lose any of my entity IDs by doing this, which would have been a real pain as I log statistics against them in InfluxDB.

No. The cause of the webscrape is having to login to the SSO site Tesla has site up. Since we’re simulating the Tesla App, oauth will not let us redirect to a non-Tesla url with the necessary login information. To my knowledge, Tesla does not have a third party API available so there’s no way to change the oauth redirrect.

I did, and it does.

Upgraded to 2021.2.3 from the prior version that I had patched, and the integration kept right on integrating without missing a beat.

If you’re struggling with patching, there’s been a promising flurry of activity today - it looks like this fix will be included in 2021.2.3, which ought not to be far away.

Many thanks to @alandtse and @bdraco for getting this over the line.

Patch works for me too. +1 vote for a working (if imperfect) integration vs a perfectly broken one.

@adebree my guess is you didn’t patch your system?

The separate driver account is just for the MFA part, not for the oauth3 issue (that is the main problem) 😃

• Subset depending on when Tesla forces the transition. Eventually will be everyone.
• Thoughts and Prayers? HA makes no timeline commitment on merge of a PR. Some integrations stay broken for months. Right now there’s a risk this will be rejected and have to be a HACS component.
• See above.

If you care enough, you can apply the PR.

@alandtse Is the reason for webscraping, because HA does not allow any OAuth2 popups for authentication? You know, like you click a button and a little Google/Microsoft/whatever web form appears (on their domain) that lets you sign in. Is that a current limitation of HA, and thus the reason for the scrape? Seems like that should be on the roadmap in general, as countless services authenticate that way. Is there an issue tracking that already?

Yes, I have a working PR submitted. It may not be allowed since it requires webscraping. So this may have to go to HACS.

Here’s a dumb question: How do I run commands / access command line?

For me I was using Home Assistant OS. The SSH and Web Terminal Community Add-on is an easy way to access the command line. The resource posted above will be helpful for accessing the host with the command line. Host access is disabled by default for security. From there it is a similar process: docker exec -it homeassistant /bin/bash cd /usr/src/homeassistant apk add patch wget https://patch-diff.githubusercontent.com/raw/home-assistant/core/pull/45766.diff patch -p1 < ./45766.diff

Getting root access was the hardest part for me. If the path /usr/src/homeassistant does not exist then you are not logged in with root access to the host.

Edit: Just had to go threw this again after updating HA. Ended up being the exact same steps layed out above. Just confusing on how to get that root access.

Just to summarize if you are using the docker container, follow these steps: docker exec -it homeassistant /bin/bash apk add patch cd /usr/src/homeassistant wget https://patch-diff.githubusercontent.com/raw/home-assistant/core/pull/45766.diff patch -p1 < ./45766.diff

Hit enter twice to ignore the test files that it tries to patch that don’t exist

Restart home assistant and your tesla integration should be working again

millerkyle72 i have passed that step, you must login as root on the core and for that is necessary to access at ssh port 22222. info here: https://developers.home-assistant.io/docs/operating-system/debugging/#ssh-access-to-the-host , then wen you log in, you run the command login at HA core, and after docker exec -it homeassistant /bin/bash

after this you will be able to access homeassistant folder: at least this i can help:

ha > login
# docker exec -it homeassistant /bin/bash
bash-5.0# ls
automations.yaml      groups.yaml           scripts.yaml
blueprints            home-assistant.log    secrets.yaml
configuration.yaml    home-assistant_v2.db  themes
custom_components     packages              tts
deps                  scenes.yaml           www
bash-5.0# cd /
bash-5.0# cd usr
bash-5.0# cd src
bash-5.0# ls
homeassistant
bash-5.0# cd homeassistant/
bash-5.0# wget https://patch-diff.githubusercontent.com/raw/home-assistant/core/       pull/45766.diff
Connecting to patch-diff.githubusercontent.com (140.82.121.4:443)
bash-5.0# patch -p1 < ./45766.diff

The workaround I posted a month or so ago is still running solid. Created a separate driver account just for HA. That user doesn’t have MFA. Haven’t missed a beat.

Sent from my iPad

On Feb 6, 2021, at 9:01 AM, Jake Burgy notifications@github.com wrote:

Really wish there was a way for Tesla owners and developers to express their frustrations somewhere where Tesla would listen to us… this is pretty ridiculous.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

Really wish there was a way for Tesla owners and developers to express their frustrations somewhere where Tesla would listen to us… this is pretty ridiculous.

P.S. Thanks to everyone here and the folks over at teslajsonpy for their hard work. You guys are doing the best you can. 🙂

No it’s not that hard. The issue is there is already a custom component for tesla so it may not make sense to have two integrations there. In fact they were working on solving this issue themselves. I may just switch over to that instead of trying to carry this along further.

Looks like they switched to OpenID Connect (or, basically OAuth2 with some fun bits on top).

https://tesla-api.timdorr.com/api-basics/authentication

It looks like there are only a few options:

• Store the user/pass so you can do a password grant each time and just get a new token when you need it
  • And of course, this falls apart for users that have MFA on, which Tesla encourages
• Do the integration setup and get a token, and have HA refresh the token in the background as long as it’s online/available to do so. The documentation example shows that the token expires in 3888000 seconds which is precisely 45 days… so this is probably the more viable option since it’s unlikely HA will be down for 45 days.
  • And even if it is, just kick off the “Integration needs attention” workflow/notification for the user to re-auth.

Was it previously using OpenID Connect, or is this new? Is that something that teslajsonpy handles or are we going to have to handle that?

<del>Just an FYI, but it loos like the tesla-api ruby gem came across this, and has documented in:</del>

<del>https://github.com/timdorr/tesla-api/issues/260</del>

<del>https://tesla-api.timdorr.com/api-basics/authentication</del>

<del>Not sure how helpful or not that is for anyone here.</del>

Never mind, just noticed that alandtse is already over in that issue so he is well aware.

It’s much more complicated. I’m taking a look now.

UPDATE: Not working yet but I’m taking a break if anyone wants to figure out why it fails exchanging the bearer token. https://github.com/alandtse/teslajsonpy/tree/oauthv3

@tobbensoft well, here it is… I wonder how far/complex is a move to the newer API

2021-01-30 19:42:32 DEBUG (MainThread) [teslajsonpy.connection] Requesting new oauth token using password
2021-01-30 19:42:32 DEBUG (MainThread) [teslajsonpy.connection] post: https://owner-api.teslamotors.com/oauth/token {'client_id': 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx', 'client_secret': 'xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx', 'grant_type': 'password', 'email': 'yann@tynsoe.org', 'password': '********************'}
2021-01-30 19:42:33 DEBUG (MainThread) [teslajsonpy.connection] 400: {"response": "endpoint_deprecated:_please_update_your_app."}
2021-01-30 19:42:33 ERROR (MainThread) [homeassistant.components.tesla.config_flow] Unable to communicate with Tesla API:

Tesla has deprecated oauth authorization, could we be running into this issue? Saw it discussed on Teslamotors subreddit.

See https://github.com/timdorr/tesla-api/issues/260