core: Songpal: Unable to make a request: 'NoneType' object is not callable
The problem
I can not see anymore the barsound device connected nor perform any servicall to it Device HT-ZF9 The device is connected correctly to internet (by lan) and is still reachable using google cast integration This happened since I updated to first beta version of 2022.9
What version of Home Assistant Core has the issue?
2022.9
What was the last working version of Home Assistant Core?
2022.8
What type of installation are you running?
Home Assistant OS
Integration causing the issue
Sony Songpal
Link to integration documentation on our website
https://rc.home-assistant.io/integrations/songpal
Diagnostics information
No response
Example YAML snippet
No response
Anything in the logs that might be useful for us?
Logger: homeassistant.components.songpal.media_player
Source: components/songpal/media_player.py:155
Integration: Sony Songpal (documentation, issues)
First occurred: 09:14:03 (8711 occurrences)
Last logged: 19:58:47
[Barra de sonido(http://xxx.xxx.x.xx:xxxxx/sony)] Got disconnected, trying to reconnect
Additional information
Device HT-ZF9 by Sony Corporation Firmware: 002.315
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Reactions: 3
- Comments: 26 (8 by maintainers)
Commits related to this issue
- Fix the default value for the notification fallback callback. After #112 the `None` value is no longer a valid fallback_callback value. Instead of allowing it, provide a default no-op callback that d... — committed to Flameeyes/python-songpal by Flameeyes 2 years ago
- Fix the default value for the notification fallback callback. After #112 the `None` value is no longer a valid fallback_callback value. Instead of allowing it, provide a default no-op callback that d... — committed to Flameeyes/python-songpal by Flameeyes 2 years ago
- Correct handling of default value for fallback_callback. After #112 the `None` value is no longer handled as a valid `fallback_callback`. This change reintroduce support for it, by considering it th... — committed to Flameeyes/python-songpal by Flameeyes 2 years ago
- Correct handling of default value for fallback_callback. After #112 the `None` value is no longer handled as a valid `fallback_callback`. This change reintroduce support for it, by considering it th... — committed to Flameeyes/python-songpal by Flameeyes 2 years ago
Still broken in 2022.9.4 that just went out.
I won’t be able to check until this weekend unfortunately.
My (incomplete) pull request might have a fix though.
@rytilahti I found the bug I introduced, sorry about that! It indeed wasn’t happening with my modified extension because I have actually been passing an explicit fallback callback.
If you can release 0.15.1 and either of us update the version required by HA, it should be enough to fix this for 2022.9.
@Homealone-2021 it is very impolite to highlight people with no reason, especially if they are not anyway involved, like Franck. Please do not do that.
The fix is already in the newest version of python-songpal, so I will create a PR to bump the dependency that should fix this for good.
edit: PR created, feel free to test it. I don’t have a test device so I cannot do that myself.
Thanks for reporting back, great that it’s working again, and thanks for @Flameeyes for such a quick fix! 🎉
I too want to express my gratitude for the quick fix! Thank you team!
Can confirm my soundbar is working again with 2022.9.5, many thanks for the very quick fix and efforts ❤️.
That’s because there has been no new releases since the fix got merged. So the upcoming 2022.9.5 release (whenever it gets released) should fix this 😃