core: luci device_tracker fix from 0.115.x incorrectly reports devices status

The problem

I use this add-on to check the state of tv/sat/audio and many other devices.

My main openwrt device is a hp t5730 with old OpenWrt 18.06.1 and serves the network for cable devices via 1G switch a TPLink(19.07.4) lan <-> wifi bridge is also connected to this switch.

So…luci-device-tracker is associated with the main cable router which is the dhcp server… and everything was working fine until this: https://github.com/home-assistant/core/pull/40160. From 0.115, some of my automations suddenly went crazy! and this applies to all devices, connected by cable and wifi every ~2 minutes their status changed home/away/home etc…

Today i found this: https://github.com/home-assistant/core/pull/40160 and at 21:10 I removed the fix temporarily and everything seems to be working fine again!

P.S. The fact that some devices remains in the dhcp table (after they physically disappear) I solved some time ago on openwrt router via shell script which every 5 minutes (from crontab) performs a ping for all devices on my subnet. This has completely eliminated reporting devices at HOME that are physically no longer in the network.

for i in $(seq 1 253)
do
  (ping 192.168.0.$i -c 1 -w 5  >/dev/null && echo "192.168.0.$i" &);
done

so it’s not an add-on problem itself

Environment

1	2
arch	armv7l
dev	false
docker	false
hassio	false
installation_type	Home Assistant Core
os_name	Linux
os_version	5.4.51-v7+
python_version	3.7.3
timezone	Europe/Warsaw
version	0.115.2
virtualenv	true

• Home Assistant Core release with the issue: 1.115.x
• Last working Home Assistant Core release (if known): 1.114.x
• Integration causing this issue: luci device_tracker
• Link to integration documentation on our website: https://www.home-assistant.io/integrations/luci/