core: Jewish Calendar - Times is broken

Home Assistant release with the issue: 0.82.1

Last working Home Assistant release (if known): Never

Operating environment (Hass.io/Docker/Windows/etc.): Docker

Component/platform: jewish_calendar - https://www.home-assistant.io/components/sensor.jewish_calendar/

Description of problem: mga_end_shma & first_stars don’t work at all. Times don’t change, and they’re completely wrong for the timezone (NY-EST).

Problem-relevant configuration.yaml entries and (fill out even if it seems unimportant):

  - platform: jewish_calendar
    language: english
    diaspora: True
    latitude: 41.0887620
    longitude: -74.0737290
    sensors:
      - date
      - weekly_portion
      - holiday_name
      - mga_end_shma  
      - first_stars

Traceback (if applicable):


Additional information: image_79

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Comments: 24 (12 by maintainers)

Commits related to this issue

Most upvoted comments

@mikeage you can open a new issue for this. You’re correct that at the moment it doesn’t show shabatot. @arigilder is helping me improve the hdate library. His latest pull request should allow us to provide such functionality. I suppose it will be merged into home assistant somewhere in the coming weeks bli neder.

@tes5884 I haven’t found the time to replicate your installation. Could you try and map /etc/timezone as well? Google tells me this might solve the issue.

FYI the goal is to ultimately have a suite of “upcoming shabbat/yom tov” sensors for jewish_calendar. I actually have this working quite nicely with a Hebcal integration right now and have some great pre-Shabbat/Yomtov automations, but as @tsvi pointed out, local calculations are better – I actually just found that to be the case with Shabbat Chanukah, where the Hebcal API spits out an illogical response for havdalah then. So the jewish_calendar sensor will use next_day to detect if it’s erev Shabbat/Yomtov.

Beyond that, hopefully we can expose more functionality to HA.