core: Can't add damping factor in Forecast.solar config UI
The problem
According to the documentation, you can set a damping factor for the morning and a damping factor for the evening seperately. But in the Options screen in the HA UI, I can only set 1 value. When I want to set 1,0, which should mean 1 damping in the morning and 0 damping in the evening, HA automatically changes the value to 1. This is unwanted, because you can have a different damping in the morning than in the evening. But HA only allows one damping factor for both.
I also tried setting the following value damping_morning=<factor1>&damping_evening=<factor2> but it looks like the field only accepts digits.
I’d like to suggest that the integration option pop-up shows a seperate damping field for morning and for evening, I believe that would fix the issue here.
What version of Home Assistant Core has the issue?
core-2023.2.0b4
What was the last working version of Home Assistant Core?
never
What type of installation are you running?
Home Assistant OS
Integration causing the issue
Forecast.Solar
Link to integration documentation on our website
https://www.home-assistant.io/integrations/forecast_solar
Diagnostics information
No response
Example YAML snippet
No response
Anything in the logs that might be useful for us?
No response
Additional information
No response
About this issue
- Original URL
- State: closed
- Created a year ago
- Reactions: 7
- Comments: 16 (6 by maintainers)
We prefer to let users set separate damping for the morning and evening. So not applying regex, but 2 separate input fields in the config flow.
Based on the updates to the python script, it looks as though the integration just needs to be updated to validate the Damping based on Regex rather than float (e.g. /^\d*.?\d*[,]?\d*.?\d+?$/gm), and then if the resulting config entry includes a comma, parse it as pass to the python script as damping_morning and damping_evening.
I’ll have a go at updating a forked version of forecast_solar and see if I can get it working.
This hasn’t been resolved yet, bump
This is a feature request and currently the integration does not support setting an morning and evening damping. It is planned to be added, because the adjustments have already been made in the python package, but the integration still needs to be adjusted.
The current damping will be used as value for the morning and evening, you can configure the configuration and then you can edit both values to whatever you like
Added!
Oh I just got this notification, but this is implemented in 2023.9. So I’ll close this issue