core: 1-wire device on RPi cannot be removed

But for 1-wire we have no way to know if the device is missing purposefully (removed) or temporarily/accidently (device failure or wiring issue) so I don’t want to implement automatic cleanup of entities. In my opinion it is better to have them unavailable (to be deleted manually) than disappearing unexpectedly.

For devices, there is definitely a case for automatic cleanup if there are no attached entities. Possibly with a code similar to this one (extracted from deconz):

    # Get registries
    device_registry, entity_registry = await asyncio.gather(
        hass.helpers.device_registry.async_get_registry(),
        hass.helpers.entity_registry.async_get_registry(),
    )

    # Generate list of all device entries
    devices_to_be_removed = [
        entry.id
        for entry in device_registry.devices.values()
    ]

    # Remove devices that don't belong to any entity
    for device_id in devices_to_be_removed:
        if (
            len(
                async_entries_for_device(
                    entity_registry, device_id, include_disabled_entities=True
                )
            )
            == 0
        ):
            device_registry.async_remove_device(device_id)

Then the last question becomes: where is it best to place this code?

• In a service (to be run manually)?
• When an entity is removed?
• During the initialisation process (gets triggered on restart)?

It seems zwave_js integration has it implemented on restart - but it’s also a complicated place as need to ensure the platforms have been fully initialised and also that server isn’t attempting to stop…

@epenet - I very much appreciate and fully support your approach !

But for 1-wire we have no way to know if the device is missing purposefully (removed) or temporarily/accidently (device failure or wiring issue) so I don’t want to implement automatic cleanup of entities. In my opinion it is better to have them unavailable (to be deleted manually) than disappearing unexpectedly.

Exactly, it may happen that wire to your sensor gets disconnected (or cut) in which case you do not want the device and entity to be removed. I would expect some sort of notification which in a way today exist in the form of WARNING in the log (maybe from user prospective it would be “nicer” to have more specific indication ? (There might be several warnings which not always gets proper attention) to give to user.

So, I would also support @Misiu to open possibility to delete device but not remove it “automatically”.

@frenck

Either contribute it, or leave this issue open as a bug report that someone could pick up 🤷

I am afraid I do not have enough knowledge to “contribute” so at this point of time I would leave it as bug report… Thanks.