android: Companion app no longer uses dark theme if companion app settings are "Dark" or "Follow System Settings" but Home Assistant is set to "Auto"

Home Assistant Android version: 2022.10.2-full

Android version: 10

Phone model: Pixel 3a

Home Assistant version: 2022.10.5

Last working Home Assistant release (if known): note that it’s the companion app that’s the problem, and the last known working version of that is 2022.10.0-full

Description of problem: In Android Companion App > Settings > Companion App > Theme I choose either “Dark” or “Follow System Settings” (which should be equivalent to “Dark” on my system). While the companion app settings screen stays in dark mode, the rest of Home Assistant within the app is light. (Home Assistant’s theme itself is set to “Auto” in “My User” > Theme.)

Traceback (if applicable, to get the logs you may refer to: https://companion.home-assistant.io/docs/troubleshooting/faqs/#android-crash-logs): N/A


Screenshot of problem: The settings page is dark, which is correct: settings page is dark

…but hitting the back button and going to the rest of Home Assistant in the companion app ignores the chosen “Dark” theme. but the rest of home assistant is light

Additional information: PR 2923 is almost certainly the culprit, and I’m guessing it has something to do with “Removing webview force dark settings”

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 58 (20 by maintainers)

Most upvoted comments

Yes, I’m running Lineage. I guess the out of date WebView is the culprit after all.

no the fix is already live in production but fire OS devices are still impacted due to them running an old version of webview

@dshokouhi Running latest WebView on this Android 9 device, with the latest beta Home Assistant app and still observing the issue.

It seems to ignore what HA’s dark/light mode preference is set to.

Combined with Android 9 having no native night mode, it always results in it selecting the light theme.

Screenshot_20221213-001642~2.png

Screenshot_20221213-002504.png

Screenshot_20221213-002633.png

Can you guide me (link) on how to get a beta? Is it sideloading (coexistence with the stable one) or replacing the stable APK? Same for the releases tab download. I’m not using Play Store by the way.

From the github releases tab: https://github.com/home-assistant/android/releases you can select the flavor you currently have installed, the labels will match the version you installed. We also use the same APK signature so it should install as an update.

Otherwise: 2022.11.0 will ship next week already right?

for the app we dont have a set release date yet, really depends on beta feedback

when will the fix arrive in a stable release (which would be 2022.10.3, right)?

I don’t think there will be a 2022.10.3 release, most likely it will be included as part of 2022.11.0.

We have had quite a bit of things get added into this current beta cycle so we usually like to let things beta for a lil bit to make sure no last minute surprises show up. The play store beta did not update last week either so we lost some beta time there.

You are more than welcome to either join the beta or install the APK off the releases tab in the meantime 😃

Didn’t want to spam the PR so I’m asking here:

when will the fix arrive in a stable release (which would be 2022.10.3, right)?

Same here–the test version of the app fixed the problem and worked correctly for me, like 2022.10.0-full and earlier.

Could anyone that is affected download a test version of the app with that code from here and report back (you need to be signed in to download, the test version will install alongside the existing app)?

Worked as before. (I tried the minimal debug) Light made it light, dark made it dark and system settings dark like my system settings.

@dshokouhi If I remember correctly you had an Amazon tablet, any chance you could check and probably reproduce this?

I have a few lol, been dealing with an outage here so will get a chance to take a closer look around Monday.