helm: when killing `helm dep up` the next `dep up` fails

when killing the process running helm dep up it sometimes leave a temporary folder named tmpcharts and this makes the next helm dep up fail with the following error.

Error: Unable to move current charts to tmp dir: rename /mychart/charts /mychart/tmpcharts: file exists

This is easily reproducable by creating a folder named tmpcharts inside an helm chart root folder and try to launch helm dep up

Of course a workaround is to remove the folder manually before running the helm dep up but that would be great that helm did that automatically somehow.

Output of helm version:

$helm version
Client: &version.Version{SemVer:"v2.12.2", GitCommit:"7d2b0c73d734f6586ed222a567c5d103fed435be", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.13.1", GitCommit:"618447cbf203d147601b4b9bd7f8c37a5d39fbb4", GitTreeState:"clean"}

Output of kubectl version:

kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.3", GitCommit:"721bfa751924da8d1680787490c54b9179b1fed0", GitTreeState:"clean", BuildDate:"2019-02-04T04:48:03Z", GoVersion:"go1.11.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.0", GitCommit:"ddf47ac13c1a9483ea035a79cd7c10005ff21a6d", GitTreeState:"clean", BuildDate:"2018-12-03T20:56:12Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.): docker for mac

The code handling this is here : https://github.com/helm/helm/blob/53d432fa58748412ff3dc10bc27cbf996d96c3ed/pkg/downloader/manager.go#L190

About this issue

Original URL
State: closed
Created 5 years ago
Comments: 26 (10 by maintainers)

Commits related to this issue

fix: dep up when exists tmpcharts Check if tmpcharts exists, and delete it before RenameWithFallback. Refs: #5567 Signed-off-by: jorgevillaverde <jorge.villaverde@toucansoft.io> — committed to jorgevillaverde/helm by jorgevillaverde 3 years ago

Most upvoted comments

re-opening. I have a PR that I will push up soon that will hopefully address all cases provided in prior PRs without introducing new bugs.

bacongobbler on Jun 29, 2021

Sounds to me like tmpcharts should instead use some unique directory in /tmp similar to what mktemp does.

lindhe on Aug 3, 2020

To solve this in my case, I had to: rm -rf charts and rm -rf tmpcharts/

It seems like helm assumes tmpcharts should not present, since it deletes it after the dependency updates, if one stops the operation in the middle this can happen.

zak905 on Aug 2, 2020

I guess this should stay open until #9889 is merged.

lindhe on Aug 9, 2021

go ahead.

bacongobbler on Aug 14, 2020

tmpcharts was introduced to fix a cross-device linking error as seen in https://github.com/helm/helm/issues/1472.

What we could do is include a defer in there to clean up the directory regardless of whether the operation succeeded or not.

Should be a simple issue to solve for those looking to contribute.

bacongobbler on Aug 14, 2020