terraform-provider-vsphere: New 'vapp properties' do not work with Ubuntu 14.04/16.04 OVA

Hi there,

Thank you for opening an issue. Please note that we try to keep the Terraform issue trackers reserved for bug reports and feature requests. For general usage questions, please see: https://www.terraform.io/community.html.

Terraform Version

terraform-vsphere$ terraform -v
Terraform v0.11.3
+ provider.vsphere v1.3.1

vSphere Provider Version

terraform-vsphere$ terraform providers
.
└── provider.vsphere 1.3.1

Affected Resource(s)

Please list the resources as a list, for example:

• vsphere_virtual_machine

Terraform Configuration Files

resource "vsphere_virtual_machine" "vm" {
  name             = "terraform-xenial"
  resource_pool_id = "${data.vsphere_resource_pool.pool.id}"
  datastore_id     = "${data.vsphere_datastore.datastore.id}"

  num_cpus = 2
  memory   = 1024
  guest_id = "ubuntu64Guest"

  network_interface {
    network_id = "${data.vsphere_network.network.id}"
  }

  disk {
    name = "terraform-xenial.vmdk"
    size = 40
  }

  vapp {
    properties {
      "password" = "super-secure-password"
      "hostname" = "custom-hostname"
    }
  }

  clone {
    template_uuid = "${data.vsphere_virtual_machine.template.id}"
  }
}

Expected Behavior

VM should have been created, and configured with the provided vApp properties.

Actual Behavior

VM hostname and password are not changed.

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

1. terraform apply

Important Factoids

• vSphere 6.5
• Official Ubuntu cloud image: https://cloud-images.ubuntu.com/xenial/current/xenial-server-cloudimg-amd64.ova (Note, the Trusty equivalent does not work either)

Using govc import.ova -options=xenial.json works as expected, where xenial.json looks like:

{
    "DiskProvisioning": "thin",
    "IPAllocationPolicy": "dhcpPolicy",
    "IPProtocol": "IPv4",
    "InjectOvfEnv": false,
    "Name": null,
    "NetworkMapping": [
        {
            "Name": "VM Network",
            "Network": ""
        }
    ],
    "PowerOn": true,
    "PropertyMapping": [
        {
            "Key": "instance-id",
            "Value": "id-ovf"
        },
        {
            "Key": "hostname",
            "Value": "custom-hostname"
        },
        {
            "Key": "seedfrom",
            "Value": ""
        },
        {
            "Key": "public-keys",
            "Value": ""
        },
        {
            "Key": "user-data",
            "Value": ""
        },
        {
            "Key": "password",
            "Value": "super-secure-password"
        }
    ],
    "WaitForIP": false
}

When deploying via vSphere GUI, these options are configurable and work as well.

References

vApp options were added in https://github.com/terraform-providers/terraform-provider-vsphere/pull/303