terraform-provider-vsphere: Importing `r/virtual_machine` with SATA disks fails with "VM resource supports SCSI disks only"

Terraform Version

0.13.1

vSphere Provider Version

1.23.0

Affected Resource(s)

• vsphere_virtual_machine

Terraform Configuration Files

resource "vsphere_virtual_machine" "vmac_terra" {
  name                  = "vmac"
  resource_pool_id      = vsphere_compute_cluster.terra.resource_pool_id
  guest_id              = "darwin16_64Guest"
  datastore_id          = data.vsphere_datastore.terra_fast.id
  num_cpus              = "2"
  memory                = "4096"
  scsi_controller_count = 0
  sata_controller_count = 1

  network_interface {
    network_id   = data.vsphere_network.terra.id
    adapter_type = "e1000e"
  }

  # cdrom {
  #   datastore_id = "datastore-10"
  #   path         = "ISO/mojave.iso"
  # }

  disk {
    label            = "disk0"
    size             = "140"
    thin_provisioned = true
    keep_on_remove   = false
    unit_number      = 0
    path             = "vmac/vmac.vmdk"
    controller_type  = "sata"
  }

  extra_config = {
    "smc.version" = "0"
  }

  lifecycle {
    ignore_changes = [
      disk,
      cdrom,
      resource_pool_id,
      clone[0].template_uuid,
    ]
  }
}

Debug Output

https://gist.github.com/kradalby/bbfd1c75fedced211e15d0390a5255d4

Expected Behavior

Virtual machine should have been imported to my TF state

Actual Behavior

Fails with:

Error: disk.0: unsupported controller type sata for disk sata:0:0. The VM resource supports SCSI disks only

Steps to Reproduce

Important Factoids

References

Support added in:

• #1118

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave “+1” or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment