terraform-provider-google: data.google_project.id breaks configs in 3.0.0-beta.1

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave “+1” or “me too” comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment
• If an issue is assigned to the “modular-magician” user, it is either in the process of being autogenerated, or is planned to be autogenerated soon. If an issue is assigned to a user, that user is claiming responsibility for the issue. If an issue is assigned to “hashibot”, a community member has claimed the issue already.

Terraform Version

Terraform v0.11.14

Affected Resource(s)

Every resource that needs to specify the project ID reference. This effects both google and google-beta provider both.

• google_…

Terraform Configuration Files

data "google_project" "project" {
  project_id = "my-project-7jewd"
}

resource "google_compute_global_forwarding_rule" "ipv4-primary" {
  name        = "primary"
  ip_address  = "${data.google_compute_global_address.ipv4.address}"
  ip_protocol = "TCP"

  port_range = "80"
  target     = "${google_compute_target_tcp_proxy.default.self_link}"
  project    = "${data.google_project.project.id}"
}

The above is one of the effected resources. Anywhere I refer the project = "${data.google_project.project.id}" it fails.

So, instead I had to update it to project = "${data.google_project.project.project_id}" to get it to work. Also, Terraform no longer identifies old resources from the existing state after I did this change, it starts to recreate everything and even fail at some points. May be because I had to do that update I mentioned to those depending resources. This causes a chain re-action accross the entire deployment.

The main problem here is in the older 2.x.x provider versions the output of ${data.google_project.project.id} is something like 'my-project-7jewd`. But now the resulting output is something like ‘projects/my-project-7jewd’.

I think this is a clear bug that needs to be addressed asap. and make sure the output of ${data.google_project.project.id} remains consistent with the earlier versions.

Debug Output

Initializing provider plugins...
- Checking for available provider plugins on https://releases.hashicorp.com...
- Downloading plugin for provider "google" (3.0.0-beta.1)...
- Downloading plugin for provider "google-beta" (3.0.0-beta.1)...

The following providers do not have any version constraints in configuration,
so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking
changes, it is recommended to add version = "..." constraints to the
corresponding provider blocks in configuration, with the constraint strings
suggested below.

* provider.google: version = "~> 3.0"
* provider.google-beta: version = "~> 3.0"

In the above init output you can clearly see that providers are sourcing a beta release of the providers. This was released earlier today.

Panic Output

Causes this type of output…

1 error occurred:
        * google_compute_target_tcp_proxy.default: 1 error occurred:
        * google_compute_target_tcp_proxy.default: Error waiting to create TargetTcpProxy: Error waiting for Creating TargetTcpProxy: error while retrieving operation: googleapi: Error 400: Invalid value 'projects/my-project-7jewd'. Values must match the following regular expression: '(?:(?:[-a-z0-9]{1,63}\.)*(?:[a-z](?:[-a-z0-9]{0,61}[a-z0-9])?):)?(?:[0-9]{1,19}|(?:[a-z0-9](?:[-a-z0-9]{0,61}[a-z0-9])?))', invalidParameter

Expected Behavior

For new 3.x.x provider upgrades the data source google_project, attribute id should be the project ID instead of having a prefix projects/ along with the project ID.

data "google_project" "project" {
  project_id = "my-project-7jewd"
}

output "gcp_project_id" {
  value = "${data.google_project.project.id}"
}

Outputs:

gcp_project_id = my-project-7jewd

Actual Behavior

data "google_project" "project" {
  project_id = "my-project-7jewd"
}

output "gcp_project_id" {
  value = "${data.google_project.project.id}"
}

Outputs:

gcp_project_id = projects/my-project-7jewd

Steps to Reproduce

1. terraform apply