gitness: E-mail plugin reports build as succesfull even though other pipelines failed
After updating to 1.0 I’ve converted a matrix build to a multi-machine with a notify step which depends on the previous pipelines, similar to what is suggested here: https://docs.drone.io/user-guide/pipeline/multi-machine/
Instead of Slack, I’m using the e-mail plugin though:
---
kind: pipeline
name: notify
clone:
disable: true
steps:
- name: notify
image: drillster/drone-email
settings:
# ...
depends_on:
- pipeline_a
- pipeline_b
trigger:
status:
- failure
Even though all pipeline_a and pipeline_b failed, I’m getting an email with the message “Successful build #xy”. I guess this is because the plugin gets the status of its own machine / pipeline, not the status of the whole build?
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 18
Commits related to this issue
- fix issue #2553 — committed to harness/gitness by bradrydzewski 5 years ago
- https://github.com/drone/drone/issues/2553#issuecomment-474865677 — committed to jhasse/drone-issue-2553 by jhasse 5 years ago
- Let saludo finish before greeting Needed to reproduce https://github.com/drone/drone/issues/2553#issuecomment-474865677 — committed to jhasse/hello-world by jhasse 5 years ago
- Update .drone.yml Needed to reproduce https://github.com/drone/drone/issues/2553#issuecomment-474865677 — committed to jhasse/hello-world by jhasse 5 years ago
Fixed by 4e4932512cc42c668cff8f627235cf1899991a28
The behavior is that the
DRONE_BUILD_STATUSwill report the global status of all pipeline steps and the newDRONE_STAGE_STATUSwill report the status of the currently executing pipeline. There should be no changes required to any of the plugins.Note that long term we will probably rename
DRONE_STAGE_variables toDRONE_PIPELINE_so that we have consistent naming, but that is out of scope for this issue 😃