Terminal.Gui: Running Wizard as a non-modal/non-popup is broken

How’s this look?

Note, I’m still playing with some layout and color things. Prepping a PR now.

@GaikwadPratik - In my fix for #1883 I have decided to make it so setting the first step explicitly is not needed IN YOUR CASE.

There is still a case where devs will need to do it, but it’s an outlier. The docs will now read:

Nope. Unrelated. I just did that because you already had a class and it was convenient vs having an ‘Wizard’ member variable.

-cek Sent via mobile. Expect brevity, typos, and dangerous driving.

---

From: Gaikwad Pratik @.> Sent: Saturday, July 23, 2022 7:22:46 AM To: migueldeicaza/gui.cs @.> Cc: Charlie Kindel @.) @.>; Mention @.***> Subject: Re: [migueldeicaza/gui.cs] Running Wizard as a non-modal/non-popup is broken (Issue #1849)

I’d just use .Visible

Okay. That makes sense. One last question for the day, In your PR to TerrminalWizard, you have inherited FirstBootWizard from Wizard because of #1883https://github.com/migueldeicaza/gui.cs/issues/1883. Once #1883https://github.com/migueldeicaza/gui.cs/issues/1883 is resolved, the inheritance becomes unnecessary correct?

— Reply to this email directly, view it on GitHubhttps://github.com/migueldeicaza/gui.cs/issues/1849#issuecomment-1193125131, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAEO6CSZXQFMBOQGKTHQCODVVPW2NANCNFSM52URIXFQ. You are receiving this because you were mentioned.Message ID: @.***>

I found your issue. When using Wizard as a non-modal, you must explicitly set the first step. This is because when running as a modal, the Loaded event is fired, and I can set the first step there, but when non-modals don’t get a Loaded event.

Maybe you can use the Initialized event instead but I’m not sure.

Nope. It doesn’t get called either for non-Modals. I’m going to submit an issue on this.

I found your issue. When using Wizard as a non-modal, you must explicitly set the first step. This is because when running as a modal, the Loaded event is fired, and I can set the first step there, but when non-modals don’t get a Loaded event.

			// When run as a modal, Wizard gets a Loading event where it sets the
			// Current Step. But when running non-modal it must be done manually.
			wizard.CurrentStep = wizard.GetNextStep ();

I should have noted this in the API documentation for Wizard; I will submit a PR to do this asap.

I’ve submitted a PR to your project with this fix and with some re-factoring to simplify your code. I also couldn’t resist cleaning some other stuff up…hope you don’t mind!

I am setting Colors.Dialog in the constructor of wizard.

Typically you want to avoid manually setting ColorScheme on an object unless you are actually trying to achieve a color change. The default behaviour of a view is to inherit from it’s parent.

So if you have a Window (defaults to Color.Base - blue background) and add a non modal View (button, label, wizard etc). Then the view will automatically take its parent color scheme.

If you have a Dialog (defaults to Color.Dialog - greyish background) and add a non modal view (button, label, wizard etc) then the view will take the parent scheme again and have a grey colored background (same as parent).

If you have ColorScheme explicitly set and you want to revert that on an instance and restore the ‘inheriting’ behaviour you can set myView.ColorScheme = null

Top also has its own color scheme which is black background and adding controls that inherit ColorScheme from parent to that often looks wierd.

I’ve recently been diving pretty deep into the ColorScheme system in designer (see https://github.com/tznind/TerminalGuiDesigner/pull/33) so might be able to help with any color related issues your having.

Thank you for clarification. Just waiting for PR to be merged and having more fun developing the app.