grpc-node: Fails to build with node.js v12.0.0 release

Problem description

../ext/channel.cc:292:56: error: too few arguments to function call, expected 2, have 1
  int try_to_connect = (int)info[0]->Equals(Nan::True());
                            ~~~~~~~~~~~~~~~            ^
/Users/mdouglass/.node-gyp/12.0.0/include/node/v8.h:2572:3: note: 'Equals' declared here
  V8_WARN_UNUSED_RESULT Maybe<bool> Equals(Local<Context> context,
  ^
/Users/mdouglass/.node-gyp/12.0.0/include/node/v8config.h:347:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))

Reproduction steps

npm init
npm install grpc@latest

Environment

macOS 10.14.4
node.js v12.0.0 installed via macOS installer from nodejs.org
gRPC 1.20.0

Additional context

Attached log files 2019-04-23T22_09_12_791Z-debug.log console.log

About this issue

Original URL
State: closed
Created 5 years ago
Reactions: 42
Comments: 33 (13 by maintainers)

Commits related to this issue

chore: disable current v12 node travis build This disables the travis build for the current Node.js version (12.0.0) until all dependencies support it. See: https://github.com/grpc/grpc-node/issues/8... — committed to ExchangeUnion/xud by sangaman 5 years ago
chore: upgrade firebase to support Node.js 12 https://github.com/grpc/grpc-node/issues/834 — committed to Leko/shotshell-journal by Leko 5 years ago
Workaround, install grpc by hand Firebase js client appears to have a dependency problem https://github.com/grpc/grpc-node/issues/834 Firebase issue tracker is a bit quiet about it, but installing ... — committed to mostalive/purescript-firebase by mostalive 4 years ago

Most upvoted comments

npm ERR! grpc@1.20.0 install: node-pre-gyp install --fallback-to-build --library=static_library npm ERR! Exit status 1 npm ERR! npm ERR! Failed at the grpc@1.20.0 install script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

I’m trying to use ( npm install ) to install a project node_modules node -v = v12.4.0 npm -v = 6.9.0 angular 8

+19

EngAhmedShehatah on Jun 10, 2019

FYI this is used in FireBase and they still ship the old version that does not work w/ Node v12. I use FireBase and that is why I’m here. Now I’m monkey patching package.json to replace what FireBase ships.

+11

cekvenich on May 1, 2019

What is the process to upgrade gprc?

npm install grpc@1.20.2 should work.

+10

sangaman on Apr 29, 2019

version 1.20.2 is now out.

murgatroid99 on Apr 29, 2019

Same issue on Ubuntu 19.04, node 12.0.0 installed with nvm, grpc 1.18.0.

sangaman on Apr 24, 2019

You are using a version of the grpc library that does not support Node 12. Please use either a newer version of grpc or an older version of Node.

murgatroid99 on Jun 24, 2019

grpc@1.20.1 is now out with Node 12 support.

murgatroid99 on Apr 26, 2019

Same issue. Had to upgrade to “grpc”: “^1.20.2”.

tdeleanu on Jul 10, 2019

does it work for yarn? I am having an issue upgrading or installing the new release but i am not sure if the issue is with grpc or other dependencies.

aaaguirrep on Apr 30, 2019

i just downgrade node (10.9.0), and fixed for now.

AHPanna on Sep 15, 2019

https://github.com/firebase/firebase-js-sdk

nicolasnoble on May 1, 2019

I would love to - but I don’t know how/where. I went on their website and filed a comment and sent a message to their group. The stack trace shows that the version they released TODAY is using the older version of grpc. I use 40 npm modules at least 10 are native and the only one w/ that does not work is Google Firebase. And no way to flag them or do PR.

cekvenich on May 1, 2019

I would suggest filling an issue with firebase then.

nicolasnoble on May 1, 2019