grails-core: Grails 5.1.6: integration tests, bootRun, bootWar are broken

Expected Behavior

integration tests should run bootRun gradle task should run bootWar war product should run

Actual Behaviour

Exception is thrown:

./gradlew bootRun

> Task :bootRun
2022-03-31 14:36:25.370 ERROR --- [  restartedMain] o.s.boot.SpringApplication               : Application run failed

org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'compositeViewResolver': Unsatisfied dependency expressed through field 'viewResolvers'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'jspViewResolver': Cannot create inner bean '(inner bean)#4f48b570' of type [grails.plugin.scaffolding.ScaffoldingViewResolver] while setting bean property 'innerViewResolver'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name '(inner bean)#4f48b570': Cannot resolve reference to bean 'groovyPagesTemplateEngine' while setting bean property 'templateEngine'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'groovyPagesTemplateEngine': Error setting property values; nested exception is org.springframework.beans.NotWritablePropertyException: Invalid property 'classLoader' of bean class [org.grails.gsp.GroovyPagesTemplateEngine]: Bean property 'classLoader' is not writable or has an invalid setter method. Does the parameter type of the setter match the return type of the getter?
        at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.resolveFieldValue(AutowiredAnnotationBeanPostProcessor.java:659)
        at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.inject(AutowiredAnnotationBeanPostProcessor.java:639)
        at org.springframework.beans.factory.annotation.InjectionMetadata.inject(InjectionMetadata.java:119)
        at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor.postProcessProperties(AutowiredAnnotationBeanPostProcessor.java:399)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1431)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:619)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
        at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
        at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
        at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
        at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
        at org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:953)
        at org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:918)
        at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:583)
        at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:145)
        at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:740)
        at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:415)
        at org.springframework.boot.SpringApplication.run(SpringApplication.java:303)
        at grails.boot.GrailsApp.run(GrailsApp.groovy:99)
        at grails.boot.GrailsApp.run(GrailsApp.groovy:485)
        at grails.boot.GrailsApp.run(GrailsApp.groovy:472)
        at test.g516.Application.main(Application.groovy:11)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.springframework.boot.devtools.restart.RestartLauncher.run(RestartLauncher.java:49)
Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'jspViewResolver': Cannot create inner bean '(inner bean)#4f48b570' of type [grails.plugin.scaffolding.ScaffoldingViewResolver] while setting bean property 'innerViewResolver'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name '(inner bean)#4f48b570': Cannot resolve reference to bean 'groovyPagesTemplateEngine' while setting bean property 'templateEngine'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'groovyPagesTemplateEngine': Error setting property values; nested exception is org.springframework.beans.NotWritablePropertyException: Invalid property 'classLoader' of bean class [org.grails.gsp.GroovyPagesTemplateEngine]: Bean property 'classLoader' is not writable or has an invalid setter method. Does the parameter type of the setter match the return type of the getter?
        at org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveInnerBean(BeanDefinitionValueResolver.java:389)
        at org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveValueIfNecessary(BeanDefinitionValueResolver.java:134)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1707)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1452)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:619)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
        at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
        at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
        at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
        at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
        at org.springframework.beans.factory.config.DependencyDescriptor.resolveCandidate(DependencyDescriptor.java:276)
        at org.springframework.beans.factory.support.DefaultListableBeanFactory.addCandidateEntry(DefaultListableBeanFactory.java:1607)
        at org.springframework.beans.factory.support.DefaultListableBeanFactory.findAutowireCandidates(DefaultListableBeanFactory.java:1571)
        at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveMultipleBeans(DefaultListableBeanFactory.java:1460)
        at org.springframework.beans.factory.support.DefaultListableBeanFactory.doResolveDependency(DefaultListableBeanFactory.java:1347)
        at org.springframework.beans.factory.support.DefaultListableBeanFactory.resolveDependency(DefaultListableBeanFactory.java:1309)
        at org.springframework.beans.factory.annotation.AutowiredAnnotationBeanPostProcessor$AutowiredFieldElement.resolveFieldValue(AutowiredAnnotationBeanPostProcessor.java:656)
        ... 26 common frames omitted
Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name '(inner bean)#4f48b570': Cannot resolve reference to bean 'groovyPagesTemplateEngine' while setting bean property 'templateEngine'; nested exception is org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'groovyPagesTemplateEngine': Error setting property values; nested exception is org.springframework.beans.NotWritablePropertyException: Invalid property 'classLoader' of bean class [org.grails.gsp.GroovyPagesTemplateEngine]: Bean property 'classLoader' is not writable or has an invalid setter method. Does the parameter type of the setter match the return type of the getter?
        at org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveReference(BeanDefinitionValueResolver.java:342)
        at org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveValueIfNecessary(BeanDefinitionValueResolver.java:113)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1707)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1452)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:619)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
        at org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveInnerBean(BeanDefinitionValueResolver.java:374)
        ... 42 common frames omitted
Caused by: org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'groovyPagesTemplateEngine': Error setting property values; nested exception is org.springframework.beans.NotWritablePropertyException: Invalid property 'classLoader' of bean class [org.grails.gsp.GroovyPagesTemplateEngine]: Bean property 'classLoader' is not writable or has an invalid setter method. Does the parameter type of the setter match the return type of the getter?
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1744)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.populateBean(AbstractAutowireCapableBeanFactory.java:1452)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.doCreateBean(AbstractAutowireCapableBeanFactory.java:619)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:542)
        at org.springframework.beans.factory.support.AbstractBeanFactory.lambda$doGetBean$0(AbstractBeanFactory.java:335)
        at org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:234)
        at org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:333)
        at org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:208)
        at org.springframework.beans.factory.support.BeanDefinitionValueResolver.resolveReference(BeanDefinitionValueResolver.java:330)
        ... 48 common frames omitted
Caused by: org.springframework.beans.NotWritablePropertyException: Invalid property 'classLoader' of bean class [org.grails.gsp.GroovyPagesTemplateEngine]: Bean property 'classLoader' is not writable or has an invalid setter method. Does the parameter type of the setter match the return type of the getter?
        at org.springframework.beans.BeanWrapperImpl.createNotWritablePropertyException(BeanWrapperImpl.java:243)
        at org.springframework.beans.AbstractNestablePropertyAccessor.processLocalProperty(AbstractNestablePropertyAccessor.java:432)
        at org.springframework.beans.AbstractNestablePropertyAccessor.setPropertyValue(AbstractNestablePropertyAccessor.java:278)
        at org.springframework.beans.AbstractNestablePropertyAccessor.setPropertyValue(AbstractNestablePropertyAccessor.java:266)
        at org.springframework.beans.AbstractPropertyAccessor.setPropertyValues(AbstractPropertyAccessor.java:104)
        at org.springframework.beans.AbstractPropertyAccessor.setPropertyValues(AbstractPropertyAccessor.java:79)
        at org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.applyPropertyValues(AbstractAutowireCapableBeanFactory.java:1740)
        ... 56 common frames omitted

Steps To Reproduce

  1. grails create-app myapp
  2. cd myapp
  3. ./gradlew bootRun

Environment Information

OS: macos JDK: openjdk version “1.8.0_302”

Example Application

No response

Version

5.1.6

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Reactions: 5
  • Comments: 28 (22 by maintainers)

Most upvoted comments

We are still working through the framework-wide implications of this issue. Spring has labeled the upstream issue as a regression. Current experimentation with Spring Core 5.3.19-SNAPSHOT has been yielding positive results. Presuming that the official release of Spring Core 5.3.19 resolves this issue and does not introduce any other complications, we will be releasing a new Grails 5.1 to use the updated dependency from Spring.

+12
JasonTypesCodes on Apr 8, 2022

Hi Team,

Is there any update to this issue or anything we can do to help on resolving this issue?

Thanks.

+11
xqliu on Apr 5, 2022

Spring Framework 5.3.19 will be released on April 13, 2022, Spring Boot 2.6.7 will be released on April 21, 2022. I test Grails 5.1.6 with Spring Framework 5.3.19-SNAPSHOT, it works now. But Grails Gradle Plugin 5.1.3 still use Spring Boot 2.6.4, we should release a new version align with Spring Boot 2.6.5 or 2.6.6.

+7
rainboyan on Apr 10, 2022

My Grails 5.1.6 app was failing due to this issue. However, when I upgrade Spring by using spring.version=5.3.19 in my gradle.properties files, it runs. Thanks!

I can confirm gradle.properties

spring.version=5.3.19

fixes this issue.

I can also confirm Grails 5.1.6 points to Spring Boot 2.6.4

@JasonTypesCodes Considering 5.1.6 is completely broken and doesn’t even point to the correct version, I would recommend releasing 5.1.7 as soon as possible.

Otherwise, anyone attempting to use the latest version of Grails will be banging their head against the wall.

https://github.com/grails/grails-core/issues/12472

+5
codeconsole on Apr 14, 2022

Spring Framework 5.3.19 and 5.2.21 are available now

In addition, Spring Framework 5.3.19 and 5.2.21 include a fix for CVE-2022-22968: Spring Framework Data Binding Rules Vulnerability and are recommended upgrades for all Spring production scenarios.

+4
rainboyan on Apr 13, 2022

+1 from me - would like to do the upgrade to get Spring’s mitigation for Spring4Shell, but currently cannot

+4
boardbloke on Apr 1, 2022

Yes, there will be a Grails 5.2.0 release soon. However, this error should be resolved with Grails 5.1.7 which updates to Spring 5.3.19.

+3
puneetbehl on Apr 27, 2022

Downgrade from Spring Framework 5.3.18 to 5.3.17, and Spring Boot 2.6.5 build and released with 5.3.17, waiting for next Grails release based on Spring Boot 2.6.6 and Spring Framework 5.3.18.

Update gradle.properties:

spring.version=5.3.17
+3
rainboyan on Apr 1, 2022

@puneetbehl Grails 5.2 branch will based on Spring Boot 2.6.x or 2.7.x? last week, Spring Boot 2.7.0-RC1 has been released, and will be GA next month.

I also noticed that Grails 6.0.x branch was created, switch to Groovy 4, is that will be using Spring Boot 3.0?

https://github.com/grails/grails-core/wiki/Roadmap was outdated a lot, the goals for the next phase should be updated. I suggest that using GH project to manage the tasks and issues, grails users and developers in the community will join discussions and give some help or feedback as they can.

+2
rainboyan on Apr 28, 2022

Grails 4 app could be upgrade to Spring Framework 5.3.18, I create another demo here, it works with grails-gsp 4.0.3, but I’m not sure it works for the other old plugins, need a lot of tests!

+2
rainboyan on Apr 3, 2022

BTW: Seems the security issue has been fixed on springboot 2.6.6, not 2.6.5, am I missing something

https://spring.io/blog/2022/03/31/spring-framework-rce-early-announcement

+2
xqliu on Apr 1, 2022

@puneetbehl Do you plan to release a new Grails version using Spring Framework 5.3.19 and Spring Boot 2.6.7?

+1
darxriggs on Apr 25, 2022

GroovyPagesTemplateEngine need a GroovyPageClassLoader, not the ref("classLoader"), so I think it may be wrong, we can remove the line or set it null, it will be initialized by initGroovyClassLoader.

    // Setup the main templateEngine used to render GSPs
    groovyPagesTemplateEngine(GroovyPagesTemplateEngine) { bean ->
        classLoader = ref("classLoader")
        groovyPageLocator = groovyPageLocator
        if (enableReload) {
            reloadEnabled = enableReload
        }
        tagLibraryLookup = gspTagLibraryLookup
        jspTagLibraryResolver = jspTagLibraryResolver
        cacheResources = enableCacheResources
    }

I have a workaround to fix this error, see the demo here -> https://github.com/rainboyan/grails-issue-12460-demo

+1
rainboyan on Apr 1, 2022
Read more comments on GitHub
← grails-core: Grails 5 - Unable to deploy on Wildfly 26.1.2
grails-core: grails install doesn't work →