setup-graalvm: 1.1.8 not updating the Windows environment variables
I am using the action like this on windows-latest:
- uses: graalvm/setup-graalvm@v1.1.7
with:
version: 22.2.0
java-version: 17
components: 'native-image'
github-token: ${{ secrets.GITHUB_TOKEN }}
cache: 'maven'
and now with 1.1.8 my windows setup stopped working.
My guess is that something is tripping up the required update to the environment variables which is still required with these older version graal versions I am sadly still stuck on.
The 1.1.7 log contains
Updating Windows environment...
while 1.1.8 does not.
Please let me know if I can provide more info.
PS Thanks for all the hard work maintaining open source software 🙏🏼
About this issue
- Original URL
- State: closed
- Created 4 months ago
- Reactions: 1
- Comments: 15 (10 by maintainers)
Commits related to this issue
- Fix GraalVM for JDK 17+ detection in MSVC feature. Fixes #88 — committed to graalvm/setup-graalvm by fniephaus 4 months ago
- Fix GraalVM for JDK 17+ detection in MSVC feature. Fixes #88 — committed to graalvm/setup-graalvm by fniephaus 4 months ago
I think I found the issue:
javaVersion === javaVersionis always true: https://github.com/graalvm/setup-graalvm/blob/5393c3d80982e8a7fa61005137824ef53731ff9a/src/msvc.ts#L35Will fix…
Thanks. Now dependabot closed the 1.1.8 issue and opened another PR for 1.1.9: https://github.com/ArloL/chorito/pull/333
I am not sure why exactly that is necessary to be honest. My guess is that they only check for x.y.z version schemes and not x.y.z.a
Thanks, @fniephaus and @bhavikp19. I too can confirm that it works: https://github.com/ArloL/chorito/actions/runs/8244996369/job/22571412312