react-native-bottom-sheet: [v4] ScrollView doesn't work inside BottomSheet

Bug

When I add ScrollView in the BottomSheet, I cannot scroll to the bottom; with the BottomSheetScrollView, I don’t have this problem, but I don’t want to expand my control to full view like does BottomSheetScrollView.

RR-2

When I added padding: 350 then, it worked fine.

RR2

Environment info

Library Version
@gorhom/bottom-sheet 4.4.3
react-native 0.68.2
react-native-reanimated ^2.9.1
react-native-gesture-handler ^2.5.0

Steps To Reproduce

  1. Try scrolling the bottom sheet to the end

Describe what you expected to happen:

  1. There is padding in the bottom, white space.

Reproducible sample code

import React, {  useMemo } from 'react';
import { StyleSheet, View,  ScrollView, Text } from 'react-native';
import BottomSheet, { BottomSheetScrollView } from '@gorhom/bottom-sheet';

const App = () => {
  const snapPoints = useMemo(() => [ '50%', '88%'], []);


  return (
    <View style={styles.container}>
      <BottomSheet
        index={0}
        snapPoints={snapPoints}
      >
        <ScrollView
          contentContainerStyle={styles.contentContainer}
        >
          <Text>
          What is Lorem Ipsum?
Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book. It has survived not only five centuries, but also the leap into electronic typesetting, remaining essentially unchanged. It was popularised in the 1960s with the release of Letraset sheets containing Lorem Ipsum passages, and more recently with desktop publishing software like Aldus PageMaker including versions of Lorem Ipsum.

Why do we use it?
It is a long established fact that a reader will be distracted by the readable content of a page when looking at its layout. The point of using Lorem Ipsum is that it has a more-or-less normal distribution of letters, as opposed to using 'Content here, content here', making it look like readable English. Many desktop publishing packages and web page editors now use Lorem Ipsum as their default model text, and a search for 'lorem ipsum' will uncover many web sites still in their infancy. Various versions have evolved over the years, sometimes by accident, sometimes on purpose (injected humour and the like).


Where does it come from?
Contrary to popular belief, Lorem Ipsum is not simply random text. It has roots in a piece of classical Latin literature from 45 BC, making it over 2000 years old. Richard McClintock, a Latin professor at Hampden-Sydney College in Virginia, looked up one of the more obscure Latin words, consectetur, from a Lorem Ipsum passage, and going through the cites of the word in classical literature, discovered the undoubtable source. Lorem Ipsum comes from sections 1.10.32 and 1.10.33 of "de Finibus Bonorum et Malorum" (The Extremes of Good and Evil) by Cicero, written in 45 BC. This book is a treatise on the theory of ethics, very popular during the Renaissance. The first line of Lorem Ipsum, "Lorem ipsum dolor sit amet..", comes from a line in section 1.10.32.

The standard chunk of Lorem Ipsum used since the 1500s is reproduced below for those interested. Sections 1.10.32 and 1.10.33 from "de Finibus Bonorum et Malorum" by Cicero are also reproduced in their exact original form, accompanied by English versions from the 1914 translation by H. Rackham.

Where can I get some?
There are many variations of passages of Lorem Ipsum available, but the majority have suffered alteration in some form, by injected humour, or randomised words which don't look even slightly believable. If you are going to use a passage of Lorem Ipsum, you need to be sure there isn't anything embarrassing hidden in the middle of text. All the Lorem Ipsum generators on the Internet tend to repeat predefined chunks as necessary, making this the first true generator on the Internet. It uses a dictionary of over 200 Latin words, combined with a handful of model sentence structures, to generate Lorem Ipsum which looks reasonable. The generated Lorem Ipsum is therefore always free from repetition, injected humour, or non-characteristic words etc.
          </Text>
        </ScrollView>
      </BottomSheet>
    </View>
  );
};

const styles = StyleSheet.create({
  container: {
    flex: 1,
  },
  bottomContainer: {
    padding: 10
  },
  contentContainer: {
    padding: 20
    //  ,paddingBottom: 350
  },
  
});

export default App;

About this issue

  • Original URL
  • State: closed
  • Created 4 years ago
  • Comments: 19

Most upvoted comments

there’s a section in the docs about this: https://gorhom.github.io/react-native-bottom-sheet/troubleshooting/#adding-horizontal-flatlist-or-scrollview-is-not-working-properly-on-android

you have to use ScrollView from 'react-native-gesture-handler' instead of react-native

If issue still persist, you may want to add enableContentPanningGesture={false} to BottomSheet component

I was having the same issue and for whatever reason doing the following seemed to work.

<ScrollView style={styles.container} waitFor={scrollViewRef}> <NativeViewGestureHandler disallowInterruption={true} ref={scrollViewRef}> (component code) </NativeViewGestureHandler> </ScrollView>

not sure if this will solve others issues as it seems to be very case by case as to what works for solving this issue currently

For those who still facing this issue, here are my fix code :

      <BottomSheetModal
        ref={bottomSheetModalRef}
        snapPoints={snapPoints}
        onChange={handleSheetChanges}>
        <BottomSheetScrollView
          onTouchStart={() => setScroll(false)}
          onTouchEnd={() => setScroll(true)}
          onTouchCancel={() => setScroll(true)}>

I was having this issue and fixed it.

  1. added missing code on MainActivity.java, from here
  2. replaced GestureHandlerRootView (app wrapping) with gestureHandlerRootHOC (app wrapping at the index.js file)
  3. Used BottomSheetScrollView (but ScrollView from react-native-gesture-handler also works)

My versions

"@gorhom/bottom-sheet": "4.4.5"
"react-native": "0.67.5"
"react-native-reanimated": "2.6.0"
"react-native-gesture-handler": "1.10.3"