react-native-bottom-sheet: [v4] enableDynamicSizing prop does not work when BottomSheetView contains a single View wrapping children
Bug
The enableDynamicSize prop does not work when BottomSheetView contains a single View component with multiple children. I am seeing inconsistent behavior where most of the time, the bottom sheet has no height and no content. Very rarely it renders correctly (maybe 1 in 50 attempts?).
I was able to reproduce this using the example app on both Android & iOS (see repro steps below).
Environment info
Reproduced on latest master (65b5dc0).
| Library | Version |
|---|---|
| @gorhom/bottom-sheet | 4.5.1 |
| react-native | 0.62.2 |
| react-native-reanimated | 2.8.0 |
| react-native-gesture-handler | 1.10.3 |
Steps To Reproduce
- Run example app
- Scroll down and click Dynamic Sizing
Describe what you expected to happen:
- Bottom sheet should render with content
Reproducible sample code
Modify the render of example/app/src/screens/advanced/DynamicSnapPointExample.tsx to add a View that wraps all children of BottomSheetView
Here is a patch file to apply with the changes: repro.patch
diff --git a/example/app/src/screens/advanced/DynamicSnapPointExample.tsx b/example/app/src/screens/advanced/DynamicSnapPointExample.tsx
index 8c3e63e..a91855e 100644
--- a/example/app/src/screens/advanced/DynamicSnapPointExample.tsx
+++ b/example/app/src/screens/advanced/DynamicSnapPointExample.tsx
@@ -54,6 +54,7 @@ const DynamicSnapPointExample = () => {
animateOnMount={true}
>
<BottomSheetView style={contentContainerStyle}>
+ <View>
<Text style={styles.message}>
Could this sheet resize to its content height ?
</Text>
@@ -62,6 +63,7 @@ const DynamicSnapPointExample = () => {
</View>
<Button label="Yes" onPress={handleIncreaseContentPress} />
<Button label="Maybe" onPress={handleDecreaseContentPress} />
+ </View>
</BottomSheetView>
</BottomSheet>
</View>
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Reactions: 27
- Comments: 46
Good workaround is using BottomShitScrollView with scroll false prop
Having the same issue with
BottomSheetView, replacing it withBottomSheetScrollViewseems to workAs others mentioned, disabling
flexand adding a min height worked for me:BottomSheetScrollViewmaybe does this too but I did not want the contents to be scrollable in my case.Not sure how related is this, but this worked for me.
deleting flex: 1 from BottomSheetView fixed same problem don’t forget r console
This isn’t stale
Same here, the only solution that works is using
BottomSheetScrollView. The docs are wrong ATM. Thx for the tip guys!As of today, the most reasonable workaround seems to be the
BottomSheetScrollView:This seems to be a workaround but I can’t get paddingBottom to work with it. How are you styling on devices with safe area bottom? I was giving paddingBottom as bottom from useSafeAreaInsets and giving a backgroundColor to BottomSheetView. That doesn’t work anymore using enableDynamicSizing.
@gorhom Any idea on how to fix this?
Adding code below
@rorycaseyap in v5 this worked for me
For anyone who is struggling with the issue. I’m using version 4.6.3 and getting the dynamic sizing is working properly. Here is my code:
Usage in a component:
https://github.com/gorhom/react-native-bottom-sheet/assets/72242664/c6e4d07c-c0f2-4066-ad1c-4053dab606db
enableDynamicSizingdoes not work if usingBottomSheetFlatListinsideDynamic sizing is working for me in version “4.6.1”
https://github.com/gorhom/react-native-bottom-sheet/assets/79057289/83a08db4-1c61-4b0a-8124-8c858219f4e9
try this https://github.com/gorhom/react-native-bottom-sheet/issues/1573#issuecomment-2468368827
AFAIK not stale still
I had to go back to the deprecated dynamic snap points with the bottomsheetview hook as a workaround
@gorhom Hey man. Thanks for all your hard work. Tagging you here as this is stopping me from upgrading. It would be amazing if you could look into it.