goreleaser: [Bug]: Goreleaser silently for invalid credentials on S3 uploads

What happened?

When doing a release with S3 my credentials were not set properly. goreleaser ran to completion and did not raise any errors that the S3 uploads fail.

How can we reproduce this?

  1. Create a .goreleaser.yml that uploads to an S3 bucket.
  2. Remove credentials that give write access to that bucket
  3. Run goreleaser

This should run to completion without alerting that the S3 uploads failed.

goreleaser version

goreleaser version 0.183.0
commit: be6199f08167cc85b0b16cefc02d8106237853b1
built by: homebrew

https://goreleaser.com

GoReleaser Check

  • goreleaser check shows no errors

Search

  • I did search for other open and closed issues before opening this.

Code of Conduct

  • I agree to follow this project’s Code of Conduct

Additional context

No response

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 32 (19 by maintainers)

Commits related to this issue

Most upvoted comments

ah, I think that should probably be

if cerr := w.Close(); cerr != nil {

good catch, thanks for help testing, will reopen this one!

anyone that wants to pr this change, feel free to do so 😃

Unfortunately not. I have something that works now and I don’t even have the write access to test this again right now. 😦

I actually gave up on GoReleaser and am using the AWS command line right now. The pipeline is working. Moving it back is a bit risky at this point. I might have another path to test this in a week or two.

Should we close this issue? Or what I can offer is, to do a Teams/Webex/Slack session to see the error live in action 😃 Most of the time this helps me to gather more infos. C’mon, what works and work should work in OSS too? 😛