agones: Agones fails to start the pod after update cpu limits to 1000m

What happened:

After update deployment we saw the pods not be able to start, the update was change it from 1500m to 1000m

What you expected to happen:

nothing crashes

How to reproduce it (as minimally and precisely as possible):

deploy a fleet with gameserver cpu limits to 1000m, it will work without any issue, update the fleet with other image tag, label or other change and kubectl apply -f the manifest again, you will see all the pods not being able to start.

Anything else we need to know?:

Looks like when the fleet is created does the conversion from 1000m to 1 in the cpu limit, but not in the update of the fleet.

Environment:

  • Agones version: 1.1.0
  • Kubernetes version (use kubectl version): Server Version: version.Info{Major:"1", Minor:"12", GitVersion:"v1.12.10", GitCommit:"e3c134023df5dea457638b614ee17ef234dc34a6", GitTreeState:"clean", BuildDate:"2019-07-08T03:40:54Z", GoVersion:"go1.10.8", Compiler:"gc", Platform:"linux/amd64"}
  • Cloud provider or hardware configuration: AWS/kops
  • Install method (yaml/helm): yaml

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Comments: 18 (5 by maintainers)

Most upvoted comments

Tested my proposed solution with changing deepequal to more accurate equal function works. And we can set 1000m and Fleet work as it should, without infinite loop and creating 5 GameServerSets per a Fleet.