fontmake: Hebrew non-VF fonts have missing entries in GDEF - GlyphClassDef.

The source: https://github.com/googlei18n/noto-source/blob/master/src/NotoSansHebrew-MM.glyphs

Pipeline generated font: https://github.com/googlei18n/noto-fonts/blob/master/alpha/from-pipeline/unhinted/ttf/sans/NotoSansHebrew-Regular.ttf Glyphs.app generated font: https://github.com/googlei18n/noto-fonts/blob/master/alpha/from-glyphsapp/unhinted/ttf/sans/NotoSansHebrew-Regular.ttf

test cases:

	<p style="font-weight:700">וַיִּפֶן אַחֲרָיו וַיִּרְאֵם,</p>
	<p style="font-weight:700">וַיְקַלְלֵם בְּשֵׁם יְהוָה;</p>

the differences using fontdiff

[pipeline is lower/green, note additional spacing] he-001

[pipeline is lower/green, note additional spacing, but also notice shift of diacritics to the left of “w-like” letter] he-002

The font generated from the same sources by the Glyphs.app appears to behave correctly.

About this issue

Original URL
State: closed
Created 7 years ago
Comments: 45 (17 by maintainers)

Commits related to this issue

Set IgnoreMarks by default in kernFeatureWriter https://github.com/googlei18n/fontmake/issues/273 — committed to punchcutter/ufo2ft by deleted user 7 years ago

Most upvoted comments

The marks have a non-zero advance so it’s definitely the issue @anthrotype mentioned. I almost have a pull request ready for glyphsLib where I could fit this in as it’s related.

punchcutter on Mar 14, 2017

@marekjez86 As a test I created a new virtual machine (OS X 10.12.4) with absolutely nothing on it. I installed git, cloned noto-source and fontmake, built fontmake and generated the Hebrew Sans and the fonts are identical to what I’m getting already which looks correct. Maybe there’s a difference in fontdiff. I’m using dev version on OS X and not seeing the spacing shown above.

punchcutter on Apr 5, 2017

I realized I need to check my hard buzz version.

marekjez86 on Apr 5, 2017