skaffold: `skaffold dev` doesn't clean up deployments on Windows

Expected behavior

Skaffold cleans up all deployments when dev mode is exited.

Actual behavior

Skaffold doesn’t clean up any deployments when dev mode is exited.

Information

After pressing Ctrl + c to exit dev mode, I see “Cleaning up…” in the logs, which exits immediately. No timing was issued for the clean up, so I suspected it didn’t happen, and checking for pods in my cluster, I see the getting-started pod left over.

$ kubectl get po --all-namespaces
NAMESPACE     NAME                               READY   STATUS    RESTARTS   AGE
default       getting-started                    1/1     Running   0          9m54s

Skaffold version: v1.8.0
Minikube version: minikube version: v1.9.2 commit: 93af9c1e43cab9618e301bc9fa720c63d5efa393
Operating system: Windows 10 Pro (1903)

Steps to reproduce the behavior

Run skaffold dev in our getting-started example.
Press Ctrl + c
Run kubectl get po --all-namespaces

About this issue

Original URL
State: closed
Created 4 years ago
Reactions: 3
Comments: 25 (14 by maintainers)

Most upvoted comments

Yeap it works perfectly using the binary directly !

isengartz on Mar 1, 2021

can you try downloading the binary directly? I’ve seen other issues around Chocolatey (see #4815)

https://storage.googleapis.com/skaffold/releases/latest/skaffold-windows-amd64.exe

gsquared94 on Mar 2, 2021

I’ve been running into the same problems with clean-up on windows. Just tried 1.13.2 (chocolately install/upgrade didn’t work, tried downloading a bad url) - I manually installed 1.13.2 and it ran great!

@briandealwis - thank you!!

edit: I grabbed a video of the upgrade failure and created a new ticket, not sure if it’s actually a skaffold problem or not: https://github.com/GoogleContainerTools/skaffold/issues/4717 edit: It’s already fixed 😃

avgojzack on Aug 25, 2020