skaffold: Fails to clean up on Ctrl+C

Not sure if I am doing something wrong, but my skaffold no longer wants to clean up when I stop the process. According to the dry run, it’s creating resources instead of deleting them (please see below).

Expected behavior

Skaffold shuts down gracefully removing created containers and images.

Actual behavior

This error message is written in the log, skaffold exits leaving running containers behind.

WARN[0192] deployer cleanup: reading manifests: kubectl create: 
Running [kubectl --context docker-for-desktop create --dry-run -oyaml 
-f /Users/dmoore/projects/test-org-api/app/api/k8s/api.yaml 
-f /Users/dmoore/projects/test-org-api/app/db/k8s/000-role.yaml 
-f /Users/dmoore/projects/test-org-api/app/db/k8s/020-stolon-sentinel.yaml 
-f /Users/dmoore/projects/test-org-api/app/db/k8s/030-secret.yaml 
-f /Users/dmoore/projects/test-org-api/app/db/k8s/040-stolon-keeper.yaml 
-f /Users/dmoore/projects/test-org-api/app/db/k8s/050-stolon-proxy.yaml 
-f /Users/dmoore/projects/test-org-api/app/db/k8s/060-init-db-job.yaml]: 
stdout , stderr: , err: signal: interrupt: signal: interrupt 

Information

  • Skaffold version: v0.27.0
  • Operating system: MacOS Mojave 10.14.4
  • Contents of skaffold.yaml:
apiVersion: skaffold/v1beta8
kind: Config
deploy:
  kubectl:
    manifests:
    - app/db/k8s/000-role.yaml
    - app/db/k8s/010-role-binding.yaml
    - app/db/k8s/020-stolon-sentinel.yaml
    - app/db/k8s/030-secret.yaml
    - app/db/k8s/040-stolon-keeper.yaml
    - app/db/k8s/050-stolon-proxy.yaml
    - app/db/k8s/060-init-db-job.yaml
    - app/api/k8s/api.yaml
profiles:
- name: dev
  activation:
    - kubeContext: docker-for-desktop
      command: dev
  build:
    artifacts:
    - image: dl-org-db
      docker:
        dockerfile: app/db/Dockerfile
        buildArgs:
          pull: false
    - image: dl-org-api.dev
      context: .
      sync:
        dist/api/**/*: app/api/
      docker:
        dockerfile: app/api/Dockerfile
        target: dev-env
        buildArgs:
          pull: false

Steps to reproduce the behavior

  1. I run my project with skaffold dev --port-forward=false
  2. I hit Ctrl+C after some time.

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Comments: 28 (24 by maintainers)

Most upvoted comments

@balopat Should not this issue be re-opened?

Clean up on ctrl-c does not work for me either

with

  • skaffold 0.39.
  • minikube v1.3.1 (hyper-v)
  • windows 10

It says "Cleaning up…’ on Ctrl-c but nothing happens

Bad news. I was using the latest 81c50fe and just hit [Ctrl]+C. The skaffold process quit immediately leaving behind everything running in k8s cluster. Had to run skaffold delete --kube-context=docker-desktop -p dev again to clean things up.

UPDATE: Been working with this version for the past couple of hours and skaffold failed to clean up on each [Ctrl]+C so far.

@demisx this should be now fixed #2746. In case of remoteManifests issues might still exist, but you are not using those seemingly.