kaniko: Number of layers inconsistent with kaniko builds that copy/copy the same files multiple times
The integration test run for https://github.com/GoogleContainerTools/kaniko/pull/249 failed even though the PR is fixing a typo in a README.
Seems like we either have a flakey test or the test is broken! 😮
++ go test
--- FAIL: TestLayers (49.18s)
--- FAIL: TestLayers/test_layer_dockerfiles/Dockerfile_test_copy_reproducible (2.70s)
integration_test.go:250: incorrect offset between layers of gcr.io/kaniko-test/docker-dockerfile_test_copy_reproducible and gcr.io/kaniko-test/kaniko-dockerfile_test_copy_reproducible: expected 0 but got 1
FAIL
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 18 (14 by maintainers)
Commits related to this issue
- Add a bit more context to layer offset failures In #251 we are investigating test flakes due to layer offsets not matching, this change will give us a bit more context so we can be sure which image h... — committed to bobcatfish/kaniko by bobcatfish 6 years ago
- Add a bit more context to layer offset failures In #251 we are investigating test flakes due to layer offsets not matching, this change will give us a bit more context so we can be sure which image h... — committed to bobcatfish/kaniko by bobcatfish 6 years ago
- Add a bit more context to layer offset failures In #251 we are investigating test flakes due to layer offsets not matching, this change will give us a bit more context so we can be sure which image h... — committed to bobcatfish/kaniko by bobcatfish 6 years ago
- Sync filesystem before snapshotting so mtime can be relied on The default hashing algorithm used by kaniko to determine if two files are the same uses the files' mtime (the inode's modification time)... — committed to bobcatfish/kaniko by bobcatfish 6 years ago
- Sync filesystem before snapshotting so mtime can be relied on The default hashing algorithm used by kaniko to determine if two files are the same uses the files' mtime (the inode's modification time)... — committed to bobcatfish/kaniko by bobcatfish 6 years ago
- Sync filesystem before snapshotting so mtime can be relied on The default hashing algorithm used by kaniko to determine if two files are the same uses the files' mtime (the inode's modification time)... — committed to bobcatfish/kaniko by bobcatfish 6 years ago
- Don't copy same files twice in copy integration tests The default hashing algorithm used by kaniko to determine if two files are the same uses the files' mtime (the inode's modification time). It tur... — committed to bobcatfish/kaniko by bobcatfish 6 years ago
- Don't copy same files twice in copy integration tests The default hashing algorithm used by kaniko to determine if two files are the same uses the files' mtime (the inode's modification time). It tur... — committed to bobcatfish/kaniko by bobcatfish 6 years ago
- Always snapshot files in COPY and RUN commands Kaniko uses mtime (as well as file contents and other attributes) to determine if files have changed. COPY and ADD commands should _always_ update the m... — committed to bobcatfish/kaniko by bobcatfish 6 years ago
- Always snapshot files in COPY and RUN commands Kaniko uses mtime (as well as file contents and other attributes) to determine if files have changed. COPY and ADD commands should _always_ update the m... — committed to bobcatfish/kaniko by bobcatfish 6 years ago
- Always snapshot files in COPY and RUN commands Kaniko uses mtime (as well as file contents and other attributes) to determine if files have changed. COPY and ADD commands should _always_ update the m... — committed to bobcatfish/kaniko by bobcatfish 6 years ago
- Always snapshot files in COPY and RUN commands Kaniko uses mtime (as well as file contents and other attributes) to determine if files have changed. COPY and ADD commands should _always_ update the m... — committed to bobcatfish/kaniko by bobcatfish 6 years ago
- Always snapshot files in COPY and RUN commands Kaniko uses mtime (as well as file contents and other attributes) to determine if files have changed. COPY and ADD commands should _always_ update the m... — committed to bobcatfish/kaniko by bobcatfish 6 years ago
- Always snapshot files in COPY and RUN commands Kaniko uses mtime (as well as file contents and other attributes) to determine if files have changed. COPY and ADD commands should _always_ update the m... — committed to bobcatfish/kaniko by bobcatfish 6 years ago
- Always snapshot files in COPY and RUN commands Kaniko uses mtime (as well as file contents and other attributes) to determine if files have changed. COPY and ADD commands should _always_ update the m... — committed to bobcatfish/kaniko by bobcatfish 6 years ago
Aw yeah, eventually consistent github commenting 😎
~thought I had reproduced this with some other images~
lol nope, that was a bug I introduced into the test XD
Another example from #256 - I’LL GET TO YOU YET
YOUR DAYS ARE NUMBERED JUST LIKE YOUR LAYERS