critters: Incompatible with html-webpack-plugin v4
When used with latest version of html-webpack-plugin, it crashes with Error: Could not find HTML asset.
It seems the html-webpack-plugin no longer uses the file name as the key in the assets object?
I can also see there’s a #43 - anything I can do to move this forward?
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Reactions: 11
- Comments: 24
Commits related to this issue
- fix: add createRequire for try/catched require('html-webpack-plugin').getHooks(compilation) #43 #52 #62 #84 — committed to dmnsgn/critters by dmnsgn 3 years ago
Hopefully fixed by #84.
@developit is there any changes this issue will be fixed?
I patched the
distfile manually and tested on one of the repos - the HTML output is identical as before (for practical purposes), so it seems to me that it works 👍.https://github.com/GoogleChromeLabs/critters/pull/43
+10000 !!!