lighthouse: False positive on noscript tag

Summary

I created a new app using preact-cli:

preact create default <appname>
cd <appname>
npm run serve

screen shot 2018-08-25 at 10 33 02 am

I added a noscript tag in the main component and it is shown when i disable JS however the score on lighthouse is still at 82 and it says that i should add a noscript tag.

    return (
      <div id="app">
        <noscript>
          <div style="position: fixed; top: 0px; left: 0px; z-index: 3000; 
                      height: 100%; width: 100%; background-color: #FFFFFF">
            <p style="margin-left: 10px">JavaScript is not enabled.</p>
          </div>
        </noscript>
				<Header />
				<Router onChange={this.handleRoute}>
					<Home path="/" />
					<Profile path="/profile/" user="me" />
					<Profile path="/profile/:user" />
				</Router>
			</div>
    );
  }

About this issue

  • Original URL
  • State: closed
  • Created 6 years ago
  • Comments: 18 (9 by maintainers)

Most upvoted comments

Oooooh of course, I forgot about this thank you very much for tracking it down @justinribeiro! #1217 captures this issue as well. I’ll go ahead and close, but I’m open to a PR adding this note to the documentation 😃

It’s a known issue with simplehttp2server that the connection is reset for the http > https redirect (there’s even an older comment noting this causes issues for LH) https://github.com/GoogleChromeLabs/simplehttp2server/issues/33