google-cloud-python: Pubsub system test: test_fetch_delete_subscription_w_deleted_topic does not see orphan w/o topic

From: https://travis-ci.org/GoogleCloudPlatform/gcloud-python/builds/151011241#L822

======================================================================
FAIL: test_fetch_delete_subscription_w_deleted_topic (pubsub.TestPubsub)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/GoogleCloudPlatform/gcloud-python/system_tests/pubsub.py", line 273, in test_fetch_delete_subscription_w_deleted_topic
    self.assertTrue(orphaned.topic is None)
AssertionError: False is not true
----------------------------------------------------------------------

About this issue

Original URL
State: closed
Created 8 years ago
Comments: 22 (22 by maintainers)

Most upvoted comments

When running .tox/system-tests/bin/nosetests system_tests/pubsub.py I was confused by

/usr/lib/python2.7/unittest/case.py:340: RuntimeWarning: TestResult has no addExpectedFailure method, reporting as passes
  RuntimeWarning)

since unittest.TestResults implements addExpectedFailure. This was due to https://github.com/nose-devs/nose/issues/33, so I feel somewhat happy with the move to py.test, where issues won’t live on unfixed for 5 years. (Thanks @jonparrott for pointing out the stagnancy of nose.)

dhermes on Sep 12, 2016

@tmatsuo Has there been some recently-deployed change to the Pubsub API which would cause this failure to go from “flaky” to “fails routinely”? Our current backoff ends up polling for four minutes, trying to get the deleted-topic response after deleting our “orphan” subscription’s topic.

@dhermes, @daspecster If @tmatsuo doesn’t know / suspect any back-end change which would explain the failures, I propose we drop this particular testcase: we have unittests in place which cover the oddball case, and we need to have our build stay green.

tseaver on Aug 28, 2016