site-kit-wp: Cannot read properties of undefined (reading 'isAdSenseLinked')

Bug Description

One user in the support forums reported the following error:

Cannot read properties of undefined (reading 'isAdSenseLinked')

    in ModuleTopEarningPagesWidget
    in WhenAnalyticsActive(ModuleTopEarningPagesWidget)
    in WidgetRenderer
    in div
    in Cell
    in WidgetCellWrapper
    in div
    in Row
    in div
    in div
    in ForwardRef
    in WidgetAreaRenderer
    in div
    in WidgetContextRenderer
    in ModuleApp
    in GoogleSitekitModule
    in RestoreSnapshots
    in ErrorHandler
    in Root

This was the sole occurrence and unfortunately we don’t have more insights other than the above.

While we don’t have the users site heath information from checking their site it looks like they have Advanced Ads active, along with WC Font end manager, elementor and Google Analytics for WordPress. I also noticed they have the AdSense snippet from Site Kit placed twice, also something we haven’t came across previously:

Steps to reproduce

Unable to reproduce, with no further insights provided.

Additional Notes

• SK 1.48.1
• Unknown if issue remains or where this appears
• No response from impacted user

---

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

• No errors should be raised due to destructuring a potentially undefined value due to a problem with useSelect:
  • useSelect calls that include multiple select usages to return an object with multiple values should be split into individual calls to useSelect, unless that’s not possible in a straightforward manner (e.g. if there is logic relating to multiple select usages in there).
  • All useSelect calls where the result is then destructured (i.e. expects an object), should be rewritten to include a || {}, to avoid a JS error in case the return value is undefined.

Implementation Brief

• Find all the instances of useSelect calls where the returned value is being destructured. ie. by searching for } = useSelect.
• The getDateRangeDates can be safely destructured and should be kept as is.
• In assets/js/components/notifications/WPVersionBumpNotification.js
  • Instead of destructuring version from the getWPVersion selector, make sure the selector is not undefined and return the version directly, otherwise return undefined.
• Do the same in the following files for the mentioned selectors.
  • getModule
    • assets/js/components/ViewOnlyMenu/Service.js
    • assets/js/modules/idea-hub/components/dashboard/DashboardCTA.js
    • assets/js/modules/idea-hub/components/setup/SetupForm.js

Test Coverage

• No tests should be failing.

QA Brief

• Note: The changes implemented don’t include any feature/UI changes.
• Set up Sit Kit and all the modules and ensure no regressions.
• Connect and disconnect the modules and ensure no regressions.
• If possible, ensure the JS error Cannot read properties of undefined is not reproducible.
• Areas to focus:
  • Splash screen
  • Analytics, Adsense, Tag Manager setup and settings screens
  • View only menu dropdown

Changelog entry

• Update certain selector usage to avoid crashing the dashboard in the event of an error.