gvisor: Latest version of shim hang when using with containerd

Description

When using latest version of shim from source with containerd, the container can’t be started. It seems to hang when creating the task. This works with older version of shim from https://github.com/google/gvisor-containerd-shim/pull/28

Steps to reproduce

Run containerd
Install containerd-shim-runsc-v1 from gvisor
Run the following

ctr image pull docker.io/library/debian:latest
ctr run --rm --runtime io.containerd.runsc.v1 docker.io/library/debian:latest demo echo CLOUD

expects to see status code = 0, and CLOUD output

Environment

Please include the following details of your environment:

runsc version release-20200928.0-105-g51913ba400cc
spec: 1.0.1-dev

containerd github.com/containerd/containerd v1.4.0-42-gefa0e809 efa0e809135e440995c6e92ca21b3545659d906b

About this issue

Original URL
State: open
Created 4 years ago
Comments: 15 (12 by maintainers)

Most upvoted comments

Right now the code in the shim strictly needs the annotation to work right. Probably we can fix this to set p.Sandbox to true when the annotations aren’t set. https://github.com/google/gvisor/blob/07a78ecb2918905af030a8cf81ee86ddd1c622c5/pkg/shim/service.go#L964

I’ll try to find a bit of time this week to make the change and test.

ianlewis on Apr 10, 2022