go-github: github actions date not getting parsed by go-github

github actions log:

19:45:30 main.go:110: parsing time ""8/18/2019 7:44:51 PM"" as ""2006-01-02T15:04:05Z07:00"": cannot parse "/2019 7:44:51 PM"" as "2006"
##[error]Docker run failed with exit code 1

this is on line 110, github.ParseWebHook , it’s working with any other payload if I just use it from a regular curl command. but it’s failing when used with GithubActions.

data, err := ioutil.ReadFile(cmClient.inputFilePath)
if err != nil {
	log.Fatalln(err)
}
// Parsing event.json.
event, err := github.ParseWebHook("issue_comment", data)
if err != nil {
	log.Fatalln(err)
}

data == issue_comment payload

not sure if this is a github action issue or go-github issue. how can i help to resolve this?

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Comments: 25 (1 by maintainers)

Commits related to this issue

Most upvoted comments

@srvaroa sorry for the delay. The deployment rolled out to the first ring, but has not progressed further yet. My guess is it will deploy to the rest of the accounts tomorrow or Friday. I’ll touch base with the folks driving the deployment tomorrow. Lots of relevant folks are at an all day event again tomorrow, so might be friday.

@VladMasarik @srvaroa the fix has rolled out everywhere now.

We tried to roll it out yesterday, but hit a snag during the deployment. Done now.

So… can this issue be closed for this repo?

@VladMasarik sorry about the regression. The timestamp from the event data was unintentionally getting mutated. The fix is merged into the production branch and should roll out with tomorrow’s hotfix train.