upload-cloud-storage: After refactor in version v0.10.0 mime types are often wrong

TL;DR

In version v0.10.0 all files our files get the mime type image/svg+xml in the GCP bucket.

Expected behavior

Previous version got the correct mime type based on file.

Observed behavior

All files (.js, .css etc) all get image/svg+xml as mime typ in GCP

Action YAML

name: Deploy production

on:
  push:

jobs:
  deploy-production:
    runs-on: ubuntu-latest
    name: Deploy
    permissions:
      contents: 'read'
      id-token: 'write'

    steps:
      - uses: actions/checkout@v2
        with:
          ref: main

      - uses: actions/setup-node@v2
        with:
          node-version: '16.13'

      - name: Install
        run: npm i

      - name: Build
        run: npm run build

      - id: 'auth'
        uses: 'google-github-actions/auth@v0'
        with:
          credentials_json: '${{ secrets.GCP_CREDENTIALS_PRODUCTION }}'

      - id: 'upload-build-folder'
        uses: 'google-github-actions/upload-cloud-storage@v0'
        with:
          path: './build'
          destination: 'path/to/folder'
          parent: false

Log output

No response

Additional information

No response

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Reactions: 9
  • Comments: 16 (3 by maintainers)

Most upvoted comments

Interestingly pointing to specific version like google-github-actions/upload-cloud-storage@v0.8.0 doesn’t fix the issue.

For us google-github-actions/upload-cloud-storage@v0.9.0 worked

Sorry, for confusion. Locking to specific version like v0.8.0 or v0.9.0 works for us too. There was another unrelated issue.

Btw, looks like locking down CI dependency versions is a good practice 👍

Hey folks - I’ve just released v0.10.1 (and the tag for v0 now also points to this new version). Please give it a try and report back. The root cause here is actually a bug in a downstream client library where an object property was being copied onto future uploads.

same, glad we aren’t the only idiots not locking down their action versions lol

@spathon did this as well can confirm it worked for us ^^^