dagger: Release build crash using 2.31-alpha

Hi,

My release version runs just fine with 2.30.1-alpha. However, with the new version, the release version fails (at app startup) with this stacktrace:

java.lang.IllegalAccessError: Interface e.b.b.c.c.a$a implemented by class com.peterlaurence.trekme.TrekMeApp_HiltComponents$ActivityC is inaccessible (declaration of 'com.peterlaurence.trekme.TrekMeApp_HiltComponents$ActivityC' appears in base.apk)
        at com.peterlaurence.trekme.DaggerTrekMeApp_HiltComponents_SingletonC$ActivityRetainedCImpl.activityComponentBuilder(Unknown Source:0)
        at e.b.b.c.d.a.a(Unknown Source:79)
        at e.b.b.c.d.a.generatedComponent(Unknown Source:11)
        at com.peterlaurence.trekme.Hilt_MainActivity.generatedComponent(Unknown Source:4)
        at com.peterlaurence.trekme.Hilt_MainActivity.inject(Unknown Source:7)
        at com.peterlaurence.trekme.Hilt_MainActivity.onCreate(Unknown Source:0)
        at com.peterlaurence.trekme.MainActivity.onCreate(Unknown Source:0)
        at android.app.Activity.performCreate(Activity.java:8000)
        at android.app.Activity.performCreate(Activity.java:7984)
        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1309)
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3404)
        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3595)
        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:85)
        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2066)
        at android.os.Handler.dispatchMessage(Handler.java:106)
        at android.os.Looper.loop(Looper.java:223)
        at android.app.ActivityThread.main(ActivityThread.java:7660)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:592)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:947)

Is there some proguard rule I should add?

About this issue

Original URL
State: closed
Created 3 years ago
Reactions: 11
Comments: 19 (3 by maintainers)

Commits related to this issue

Make Hilt internal entry point and modules public to avoid r8 optimization issues. This CL is a partial rollback of changes made in CL/351213437 when introducing TestInstallIn. Making these classes p... — committed to google/dagger by bcorso 3 years ago
Revert Hilt internal entry point and modules back to public to avoid r8 optimization issues. This CL is a partial rollback of changes made in CL/351213437 when introducing TestInstallIn. Making these... — committed to google/dagger by bcorso 3 years ago
Revert Hilt internal entry point and modules back to public to avoid r8 optimization issues. This CL is a partial rollback of changes made in CL/351213437 when introducing TestInstallIn. Making these... — committed to google/dagger by bcorso 3 years ago

Most upvoted comments

@peterLaurence I use a keepnames proguard rule !

 -keepnames class dagger.**

satoshun on Jan 21, 2021

I got a same issue when release build.

Added proguard rules and output logs.

Process: my.app.dev, PID: 4079
java.lang.IllegalAccessError: Interface dagger.hilt.android.internal.lifecycle.DefaultViewModelFactories$ActivityEntryPoint implemented by class my.app.App_HiltComponents$ActivityC is inaccessible (declaration of 'my.app.App_HiltComponents$ActivityC' appears in /data/app/~~FM-gpW7f2V-7shmQqvIcog==/my.app.dev-I_VxkFwsLMsITVbsHfv9JQ==/base.apk)
    at my.app.DaggerApp_HiltComponents_SingletonC$ActivityRetainedCImpl.a(DaggerApp_HiltComponents_SingletonC.java:3652)
    at dagger.hilt.android.internal.managers.ActivityComponentManager.a(ActivityComponentManager.java:88)
    at dagger.hilt.android.internal.managers.ActivityComponentManager.I(ActivityComponentManager.java:66)
    ...

satoshun on Jan 20, 2021

@bcorso : it just the unscramble stack trace, hope it helps. Triggered with version 2.31-alpha. Update to 2.31.2 fix the issue.

ColinAygalincSe on Jan 25, 2021

Hi, get the same issue. Here is the unscramble stack trace :

 at com.schneiderelectric.configelec.application.DaggerScotApplication_HiltComponents_SingletonC$ActivityRetainedCImpl.activityComponentBuilder(DaggerScotApplication_HiltComponents_SingletonC.java:0)
    at dagger.hilt.android.internal.managers.ActivityComponentManager.createComponent(ActivityComponentManager.java:79)
    at dagger.hilt.android.internal.managers.ActivityComponentManager.generatedComponent(ActivityComponentManager.java:11)
    at com.se.module.wiserhome.ui.activity.Hilt_WiserHomeActivity.generatedComponent(Hilt_WiserHomeActivity.java:4)
    at com.se.module.wiserhome.ui.activity.Hilt_WiserHomeActivity.inject(Hilt_WiserHomeActivity.java:7)
    at com.se.module.wiserhome.ui.activity.Hilt_WiserHomeActivity.onCreate(Hilt_WiserHomeActivity.java:0)
    at com.se.module.wiserhome.ui.activity.WiserHomeActivity.onCreate(WiserHomeActivity.java:0)
    at android.app.Activity.performCreate(Activity.java:7893)
    at android.app.Activity.performCreate(Activity.java:7880)
    at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1307)
    at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3286)
    at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3460)
    at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83)
    at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
    at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2047)
    at android.os.Handler.dispatchMessage(Handler.java:107)
    at android.os.Looper.loop(Looper.java:224)
    at android.app.ActivityThread.main(ActivityThread.java:7590)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:539)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:950)

@peterLaurence : check this blogpost to unscramble stack trace : https://segunfamisa.com/posts/analyze-stack-trace-in-android-studio

ColinAygalincSe on Jan 25, 2021

The immediate breakage caused by 2.31 has been reverted and pushed in 2.31.2. I will continue to leave this open though since the general issue still remains.

Chang-Eric on Jan 21, 2021

For anyone who wants the workaround, here is what i added to my proguard/r8 file.

-keep class  dagger.hilt.android.internal.modules.HiltWrapper_ActivityModule
-keep class dagger.hilt.android.internal.managers.HiltWrapper_ActivityRetainedComponentManager_LifecycleModule
-keep class dagger.hilt.android.internal.managers.HiltWrapper_ActivityRetainedComponentManager_ActivityRetainedLifecycleEntryPoint
-keep class dagger.hilt.android.internal.managers.HiltWrapper_ActivityRetainedComponentManager_ActivityRetainedComponentBuilderEntryPoint

-keep class dagger.hilt.android.internal.lifecycle.HiltWrapper_DefaultViewModelFactories_ActivityEntryPoint
-keep class dagger.hilt.android.internal.lifecycle.HiltWrapper_DefaultViewModelFactories_ActivityModule
-keep class dagger.hilt.android.internal.lifecycle.HiltWrapper_DefaultViewModelFactories_FragmentEntryPoint

-keep class dagger.hilt.android.internal.lifecycle.HiltWrapper_HiltViewModelFactory_ViewModelModule
-keep class dagger.hilt.android.internal.lifecycle.HiltWrapper_HiltViewModelFactory_ViewModelFactoriesEntryPoint

kenshin171 on Jan 21, 2021

@satoshun thanks for the deobfuscated error message, that helps a lot! @danysantiago was able to reproduce this locally and confirm the issue. dagger.hilt.android.internal.lifecycle.DefaultViewModelFactories$ActivityEntryPoint, was recently changed from public to pkg-private which is likely what triggered this issue.

However, I think the real issue is in r8. Hilt allows non-public entry points by generating a public wrapper for the entry point, e.g.

// Hilt generates a public wrapper for PkgPrivateEntryPoint.
public interface HiltWrapper_PkgPrivateEntryPoint extends PkgPrivateEntryPoint {}

// The generated Hilt component extends the public wrapper
@Component(...)
interface HiltComponents_SingletonC extends HiltWrapper_PkgPrivateEntryPoint {}

It sounds like this is a bug in r8 where it is incorrectly removing the wrapper during shrinking/optimization. We should file a bug for r8.

In the meantime, you can try adding a keep rule for all HiltWrapper_* classes to unblock yourself. We should probably also consider pushing another release that includes this keep rule automatically until the bug is fixed.

EDIT: Looks like the keep rule may not be enough… we’ll update once/if we’ve found a general solution. EDIT2: The keep rule does work (just need to force a rebuild in AndroidStudio since it’s not triggered automatically).

bcorso on Jan 20, 2021