dagger: Incompatible with kotlinx-metadata 0.6.0
kotlinx metadata 0.6.0 was released yesterday with a number of breaking API changes. It looks like Dagger doesn’t currently shade this dependency, so this update breaks dagger/xprocessing internally when it runs.
Caused by: java.lang.NoSuchMethodError: 'kotlinx.metadata.jvm.KotlinClassMetadata kotlinx.metadata.jvm.KotlinClassMetadata$Companion.read(kotlinx.metadata.jvm.KotlinClassHeader)'
at dagger.spi.shaded.androidx.room.compiler.processing.javac.kotlin.KotlinMetadataElement$Companion.createFor(KotlinMetadataElement.kt:125)
at dagger.spi.shaded.androidx.room.compiler.processing.javac.JavacTypeElement$kotlinMetadata$2.invoke(JavacTypeElement.kt:57)
at dagger.spi.shaded.androidx.room.compiler.processing.javac.JavacTypeElement$kotlinMetadata$2.invoke(JavacTypeElement.kt:56)
at kotlin.SynchronizedLazyImpl.getValue(LazyJVM.kt:74)
at dagger.spi.shaded.androidx.room.compiler.processing.javac.JavacTypeElement.getKotlinMetadata(JavacTypeElement.kt:56)
at dagger.spi.shaded.androidx.room.compiler.processing.javac.JavacTypeElement.isClass(JavacTypeElement.kt:136)
at dagger.internal.codegen.xprocessing.XElements.getKindName(XElements.java:557)
at dagger.internal.codegen.base.DaggerSuperficialValidation.validateTypeOf(DaggerSuperficialValidation.java:136)
Repro: https://github.com/ZacSweers/CatchUp/pull/402 (run ./gradlew :app:assembleDebug --stacktrace)
About this issue
- Original URL
- State: closed
- Created a year ago
- Reactions: 3
- Comments: 40 (6 by maintainers)
Commits related to this issue
- Shade kotlinx metadata in Dagger's artifacts. RELNOTES=Fixes #3701: Shade kotlinx metadata in Dagger's artifacts. PiperOrigin-RevId: 530726420 — committed to google/dagger by bcorso a year ago
- Shade kotlinx metadata in Dagger's artifacts. This CL also removes an extra version of auto-common that we jarjared and shaded into the Hilt compiler artifacts. In particular, since Hilt's compiler a... — committed to google/dagger by bcorso a year ago
- Shade kotlinx metadata in Dagger's artifacts. This CL also removes an extra version of auto-common that we jarjared and shaded into the Hilt compiler artifacts. In particular, since Hilt's compiler a... — committed to google/dagger by bcorso a year ago
- Shade kotlinx metadata in Dagger's artifacts. This CL also removes an extra version of auto-common that we jarjared and shaded into the Hilt compiler artifacts. In particular, since Hilt's compiler a... — committed to google/dagger by bcorso a year ago
- Shade kotlinx metadata in Dagger's artifacts. This CL also removes an extra version of auto-common that we jarjared and shaded into the Hilt compiler artifacts. In particular, since Hilt's compiler a... — committed to google/dagger by bcorso a year ago
- Shade kotlinx metadata in Dagger's artifacts. This CL also removes an extra version of auto-common that we jarjared and shaded into the Hilt compiler artifacts. In particular, since Hilt's compiler a... — committed to google/dagger by bcorso a year ago
- Shade kotlinx metadata in Dagger's artifacts. This CL also removes an extra version of auto-common that we jarjared and shaded into the Hilt compiler artifacts. In particular, since Hilt's compiler a... — committed to google/dagger by bcorso a year ago
- Shade kotlinx metadata in Dagger's artifacts. This CL also removes an extra version of auto-common that we jarjared and shaded into the Hilt compiler artifacts. In particular, since Hilt's compiler a... — committed to google/dagger by bcorso a year ago
- Bump dagger to work around incompatible metadata issue https://github.com/google/dagger/issues/3701 — committed to mateuszkwiecinski/lottie-android by mateuszkwiecinski a year ago
- Bump dagger to work around incompatible metadata issue https://github.com/google/dagger/issues/3701 — committed to mateuszkwiecinski/lottie-android by mateuszkwiecinski a year ago
- Bump dagger to work around incompatible metadata issue https://github.com/google/dagger/issues/3701 — committed to mateuszkwiecinski/lottie-android by mateuszkwiecinski a year ago
- Bump dagger to work around incompatible metadata issue https://github.com/google/dagger/issues/3701 — committed to mateuszkwiecinski/lottie-android by mateuszkwiecinski a year ago
- Bump dagger to work around incompatible metadata issue https://github.com/google/dagger/issues/3701 — committed to mateuszkwiecinski/lottie-android by mateuszkwiecinski a year ago
- Bump dagger to work around incompatible metadata issue https://github.com/google/dagger/issues/3701 — committed to mateuszkwiecinski/lottie-android by mateuszkwiecinski a year ago
Yup - We are aware of the breaking changes, I’m working on updating xprocessing which then will help Dagger (and Room) avoid the incompatibility. Thanks!
Version 2.46 does not fix this problem
same bug with v2.46
I upgraded today and getting this error on v2.46
2.46 not fixed the issue, please reopen the ticket
Bare bones repro app (if you downgrade the dagger dependency to 2.45 it works):
MyApplication.zip
We’ll revisit this, we are going to probably shade / jarjar kotlinx-metadata-jvm while Jetbrains stabilizes the APIs and it would avoid issues with other libraries using it since its a transitive dependency for Dagger / Hilt.
Thanks @danysantiago the: For others who are using Room 2.5.1 with Dagger / Hilt 2.46 then the issue is that Dagger / Hilt upgrades kotlinx-metadata-jvm to a version incompatible with Room 2.5.1 and instead Room 2.6.0-alpha01 or higher needs to be used. fixed it for me.
If you are using Hilt, update it to 2.46.1 and it will work.
why is this issue closed? none of the suggestions fixes this problem.
Same issue, not using room. But room is mentioned in the stacktrace:
xprocessing was updated in Dagger (https://github.com/google/dagger/commit/44b876daf159374a84e64a28da79efe97cf53031) fixing this issue.
Thanks, that fixed the issue for me.
Its as if something is pinning
kotlinx-metadatato something older than 0.6.0.Can you try forcing the usage of 0.6.0 by explicitly declaring it in your dependencies, for example
kapt "org.jetbrains.kotlinx:kotlinx-metadata-jvm:0.6.0"to make sure that version ofkotlinx-metadatais used during annotation processing in Kotlin.It would also be good to check the projects dependency tree to verify the right
kotlinx-metadatais being used, see https://docs.gradle.org/current/userguide/viewing_debugging_dependencies.html for info on how to check dependencies in Gradle.Lastly if there is a repro project we can try, that would be amazing, since our Gradle integration projects in https://github.com/google/dagger/tree/master/javatests/artifacts didn’t reproduce this.
Same bug on v2.46
This issue is not entire related with room also no work with kotlin 1.8.20
@ZacSweers: The warning is coming from here when a metadata for a synthetic class is found. It is probably harmless but I can see the warning being annoying… Even though these classes rarely show up in the AST they can appear in Kotlin, see this comment for example: https://github.com/google/dagger/issues/2379#issuecomment-778263561. I think this is a bit of a regression, Dagger used to error out when a synthetic class metadata was found, that was later fixed (relaxing the check) but recently Dagger switched to using xprocessing for metadata and that logic had a warning, hence its back in warning form.
@almeric Thank you sooo much for the repro. I am a bit baffled as to what is going on but I was able to pin-point the issue to Kotlin’s new-ish
jvmToolchainusage. In the provided project if you remove thejvmToolchainDSL lines and instead configure the target JVM for Kotlin tasks the ‘old way’:The project will build and right kotlinx-metadata-jvm will be in the classpath. Alternative, upgrading the toolchain version to 18 (only tried that version) also worked for me, so there is some classpath shenanigans occurring when configuring Kotlin’s JDK via the
jvmToolchainDSL APIs. If you really need to stick with JVM 11 then its worth filing a bug to the Kotlin team at https://youtrack.jetbrains.com/issues/KT.For others who are using Room 2.5.1 with Dagger / Hilt 2.46 then the issue is that Dagger / Hilt upgrades kotlinx-metadata-jvm to a version incompatible with Room 2.5.1 and instead Room 2.6.0-alpha01 or higher needs to be used.
We see a slightly different issue when forcing metadata 0.6.0
It does appear to finish the build successfully, but the above warnings are new and seem concerning