go: x/tools/internal/lsp: frequent out-of-memory errors on windows-amd64-race builder
The tests under x/tools/internal/lsp flake frequently on the windows-amd64-race builder with out of memory errors:
https://build.golang.org/log/23e29f4766fa39ac7b7945a729cec7d6ed82a41d
https://build.golang.org/log/086b928e2af996b8955666acce9c2c36ff7f82e8
https://build.golang.org/log/1c6543c8679c8710e897463a62921a3bddfa9a2e
The flakiness of these tests makes it too easy to ignore failures and miss real bugs (such as #31749) detected by the same builder: https://build.golang.org/log/2c3d2505bf5145815ce4fc57a449c39a46a32cf2
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Comments: 16 (14 by maintainers)
Commits related to this issue
- dashboard: upsize machine type for windows-amd64-{longtest,race} builders Start using n1-highcpu-8 machine type instead of n1-highcpu-4 for windows-amd64-longtest and windows-amd64-race builders. Con... — committed to golang/build by dmitshur 5 years ago
- dashboard: upsize windows-amd64-{longtest,race} builders to 14.4 GB RAM Start using n1-highcpu-16 machine type instead of n1-highcpu-8 for windows-amd64-longtest and windows-amd64-race builders. The... — committed to golang/build by dmitshur 4 years ago
Looks like the CL above helped; we got our first near-pass of x/tools on
windows-amd64-longtestbuilder in this recent run. It found #35839.