go: x/tools/gopls: sometimes documentation on hover is not shown
- VS Code
- go1.16.4
- gopls@master
For example in case of (*url.URL).Query():
About this issue
- Original URL
- State: closed
- Created 3 years ago
- Comments: 16 (7 by maintainers)
Commits related to this issue
- internal/lsp/source: re-parse if needed when collecting identifier info With the new ParseExported logic, we can lose some unexported fields on exported structs. This can lead to misleading or malfor... — committed to golang/tools by findleyr 3 years ago
- internal/lsp: improve package search in a couple places When we open a file in a package, independent of whether it is in the workspace, we type check in ParseFull mode. However, several other code p... — committed to golang/tools by findleyr 3 years ago
- internal/lsp/source: improve logic for finding full syntax in hover When enriching identifier info with full syntax, it's cleaner to find the enclosing decl. Use the full decl in hover if we were una... — committed to golang/tools by findleyr 3 years ago
The CL above should fix the issue reported by @ShoshinNikita, but I’m still not sure what’s going on in the original issue: none of the AST trimming should have dropped comments.
So I think we should leave this issue open for a little while in case the problem reoccurs and we can capture logs. Unassigning in the meantime.