go: x/mobile: Gradle version > 3.5.1 produces NullPointerException in GobindPlugin

Please answer these questions before submitting your issue. Thanks!

What version of Go are you using (`go version`)?

1.8

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (`go env`)?

linux (Ubuntu) / amd64

What did you do?

Android Studio 3.0 forced an update to Gradle plugin from 3.5.1 to 4.1x.

If possible, provide a recipe for reproducing the error.

Create an Android Studio project and add a module that uses the Gobind plugin (version 0.2.9)

Attempt to build the project

What did you expect to see?

Android Studio / Gradle should build an .aar from the Go source.

What did you see instead?

The plugin produces the following stacktrace:

FAILURE: Build failed with an exception.

What went wrong: Execution failed for task ‘:agent:gobind’. > Cannot get property ‘classpath’ on null object

* Try: Run with --info or --debug option to get more log output.

* Exception is: org.gradle.api.tasks.TaskExecutionException: Execution failed for task ‘:agent:gobind’. at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:100) at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:70) at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:63) at org.gradle.api.internal.tasks.execution.ResolveTaskOutputCachingStateExecuter.execute(ResolveTaskOutputCachingStateExecuter.java:54) at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58) at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88) at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:52) at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:52) at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54) at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43) at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34) at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.run(DefaultTaskGraphExecuter.java:248) at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:336) at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:328) at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:197) at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:107) at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:241) at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:230) at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.processTask(DefaultTaskPlanExecutor.java:124) at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.access$200(DefaultTaskPlanExecutor.java:80) at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:105) at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker$1.execute(DefaultTaskPlanExecutor.java:99) at org.gradle.execution.taskgraph.DefaultTaskExecutionPlan.execute(DefaultTaskExecutionPlan.java:625) at org.gradle.execution.taskgraph.DefaultTaskExecutionPlan.executeWithTask(DefaultTaskExecutionPlan.java:580) at org.gradle.execution.taskgraph.DefaultTaskPlanExecutor$TaskExecutorWorker.run(DefaultTaskPlanExecutor.java:99) at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:63) at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:46) at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:55) Caused by: java.lang.NullPointerException: Cannot get property ‘classpath’ on null object at org.golang.mobile.GomobileTask.gomobile(GobindPlugin.groovy:219) at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:73) at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.doExecute(DefaultTaskClassInfoStore.java:141) at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134) at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:121) at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:731) at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:705) at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter$1.run(ExecuteActionsTaskExecuter.java:122) at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:336) at org.gradle.internal.progress.DefaultBuildOperationExecutor$RunnableBuildOperationWorker.execute(DefaultBuildOperationExecutor.java:328) at org.gradle.internal.progress.DefaultBuildOperationExecutor.execute(DefaultBuildOperationExecutor.java:197) at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:107) at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:111) at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:92) … 27 more

About this issue

Original URL
State: closed
Created 7 years ago
Reactions: 3
Comments: 19 (12 by maintainers)

Commits related to this issue

misc/androidstudio: update to 0.2.10 0.2.9 was broken - for unknown reasons, the plugin was built on top of stale sources. Updates golang/go#21594 Plugin 0.2.10 was built with rev 50b7067 and this ... — committed to golang/mobile by hyangah 6 years ago
example: update android examples to use 0.2.10 plugin Also, modernize the build.gradle configurations to work with recent Android plugin (>=3.0.0) https://developer.android.com/studio/build/gradle-p... — committed to golang/mobile by hyangah 6 years ago

Most upvoted comments

Hello,

I am stuck on the same issue (NullPointerException at GobindPlugin.groovy:219), and this doesn’t seem to be related with the Gradle version (I am reproducing it with Gradle 3.5).

What feels really strange is that I am using the gomobile plugin v0.2.9 and this is supposed to be fixed by @eliasnaur in this commit. Moreover, I don’t see how there could be any NullPointerException at line 219 in the current code:

if (javaCompile) { // <- This is line 219
    def classpath = project.files(javaCompile.classpath, javaCompile.destinationDir)
    cmd << "-classpath"
    cmd << classpath.join(File.pathSeparator)
}

Out of curiosity, I opened and decompiled my gobindPlugin-0.2.9.jar, and here is what I found:

Object classpath = var1[1].call(var1[2].callGroovyObjectGetProperty(this), var1[3].callGetProperty(this.javaCompile), var1[4].callGetProperty(this.javaCompile));
var1[5].call(cmd, "-classpath");
var1[6].call(cmd, var1[7].call(classpath, var1[8].callGetProperty(File.class)));
var1[9].call(cmd, "-o");
var1[10].call(cmd, var1[11].call(this.outputFile));
var1[12].call(cmd, "-target");

This really looks like the groovy code before the fix…

According to the history the 0.2.9 version is supposed to include the fix. But is there any possibility that the wrong source code version was shipped and tagged as 0.2.9 ?

Qheb on Sep 22, 2017