go: x/build: add "slowbots" support
We aim to make TryBots be only 5 minutes, but sometimes people want long, deeper tests over all architectures.
We’ve heard from the compiler/runtime team (@martisch, et al) that a more broad TryBot mode would be useful.
I thought we had a bug for this already but can’t find it. (Maybe it was a comment on another bug)
The plan I thought writing about elsewhere was that when clicking “+1 TryBot”, you could write some magic syntax in the comment field on Gerrit to specify which extra bots run. Some other tool can help you construct that magic comment & do the Gerrit comment for you, like git-codereview does (when you specify git-codereview mail -trybot)
About this issue
- Original URL
- State: closed
- Created 5 years ago
- Reactions: 4
- Comments: 32 (26 by maintainers)
Commits related to this issue
- maintner/maintnerd: return TRY= comment directives in Run-TryBot votes For slowbots support. Updates golang/go#34501 Change-Id: I6f8a8b187c3ce4531498f106d62e29e1d1f421d8 Reviewed-on: https://go-rev... — committed to golang/build by bradfitz 5 years ago
- cmd/coordinator: add SlowBots support, opt-in to different slow trybots This parses TRY= comments to opt-in to slower/difference trybots. This needs some docs/UI work yet. Updates golang/go#34501 ... — committed to golang/build by bradfitz 5 years ago
- dashboard: add SlowBot alias for freebsd-arm64-dmgk This should fix TestSlowBotAliases on tip. Updates golang/go#24715 Updates golang/go#34501 Change-Id: I80f99a5c24ef0860717605816a753fe6625aff17 R... — committed to golang/build by tklauser 5 years ago
- maintner/maintnerd: return TRY= comment directives in Run-TryBot votes For slowbots support. Updates golang/go#34501 Change-Id: I6f8a8b187c3ce4531498f106d62e29e1d1f421d8 Reviewed-on: https://go-rev... — committed to codebien/build by bradfitz 5 years ago
- cmd/coordinator: add SlowBots support, opt-in to different slow trybots This parses TRY= comments to opt-in to slower/difference trybots. This needs some docs/UI work yet. Updates golang/go#34501 ... — committed to codebien/build by bradfitz 5 years ago
- dashboard: add SlowBot alias for freebsd-arm64-dmgk This should fix TestSlowBotAliases on tip. Updates golang/go#24715 Updates golang/go#34501 Change-Id: I80f99a5c24ef0860717605816a753fe6625aff17 R... — committed to codebien/build by tklauser 5 years ago
- cmd/coordinator: consider explicitly requested builders as SlowBots Previously, a builder was considered to be "SlowBot" whenever it was requested via the TRY= syntax, and it wasn't already a part of... — committed to golang/build by dmitshur 4 years ago
- cmd/coordinator, dashboard: don't skip cmd/dist tests for SlowBots When a user explicitly requests a SlowBot builder via the TRY= syntax, it is a signal that they're willing to wait longer for test r... — committed to golang/build by dmitshur 4 years ago
I wrote the start of some docs: https://github.com/golang/go/wiki/SlowBots
It’s alive! (on https://go-review.googlesource.com/c/go/+/171822/22#message-1627ac4750a897104245e2dc87cc20f838c0b057)
/cc @ianlancetaylor
Heh, @bradfitz used the term “SlowBots” in https://github.com/golang/go/issues/29239#issuecomment-447438842 too.
At least, until we address #29641 and #26529. 😉
Change https://golang.org/cl/201338 mentions this issue:
cmd/coordinator: add SlowBots support, opt-in to different slow trybotsLet’s not. They’re different enough and I was actually working on this one last week.
Related: